Make explicit that notifiers take ownership of Output

Author: algesten

src/actions/mod.rs

@@ -212,12 +212,12 @@ impl InitActionContext {
                 show_warnings: config.show_warnings,
                 use_black_list: config.use_crate_blacklist,
                 active_build_count: self.active_build_count.clone(),
-                notifier: Box::new(BuildDiagnosticsNotifier::new(&out)),
+                notifier: Box::new(BuildDiagnosticsNotifier::new(out.clone())),
                 blocked_threads: vec![],
             }
         };
 
-        let notifier = Box::new(BuildProgressNotifier::new(&out));
+        let notifier = Box::new(BuildProgressNotifier::new(out.clone()));
 
         self.active_build_count.fetch_add(1, Ordering::SeqCst);
         self.build_queue

src/actions/progress.rs

@@ -66,9 +66,9 @@ pub struct BuildProgressNotifier<O: Output> {
 }
 
 impl<O: Output> BuildProgressNotifier<O> {
-    pub fn new(out: &O) -> BuildProgressNotifier<O> {
+    pub fn new(out: O) -> BuildProgressNotifier<O> {
         BuildProgressNotifier {
-            out: out.clone(),
+            out,
             progress_params: new_progress_params("Build".into()),
         }
     }
@@ -104,9 +104,9 @@ pub struct BuildDiagnosticsNotifier<O: Output> {
 }
 
 impl<O: Output> BuildDiagnosticsNotifier<O> {
-    pub fn new(out: &O) -> BuildDiagnosticsNotifier<O> {
+    pub fn new(out: O) -> BuildDiagnosticsNotifier<O> {
         BuildDiagnosticsNotifier {
-            out: out.clone(),
+            out,
             progress_params: new_progress_params("Diagnostics".into()),
         }
     }