Skip to content

Commit 6cf4aa5

Browse files
epageweihanglo
andauthored
fix: Typo
Co-authored-by: Weihang Lo <[email protected]>
1 parent ec500c2 commit 6cf4aa5

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

text/3516-public-private-dependencies.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -245,7 +245,7 @@ You can't definitively lint when a `public = true` is unused since it may depend
245245
- `rustc`: Instead of `allow` by default for pre-2024 editions, we could warn by default
246246
- More people would get the benefit of the feature now
247247
- However, this would be extremely noisy and likely make people grumpy
248-
- If we did this, we'd likely want to not require an MSRV bump so people can immediately silence the warning which would require using a key besides `public` (since its already reserved) and treating the field as an unused key when the `-Z` isn't enabled.
248+
- If we did this, we'd likely want to not require an MSRV bump so people can immediately silence the warning which would require using a key besides `public` (since it's already reserved) and treating the field as an unused key when the `-Z` isn't enabled.
249249
- `Cargo.toml`: Instead of `public = false` being the default and changing the warning level on an edition boundary, we could instead start with `public = true` and change the default on an edition boundary.
250250
- This would require `cargo fix` marking all dependencies as `public = true`, while using the warning means we can limit it to only those dependencies that need it.
251251
- `Cargo.toml`: Instead of `public = false` being the default, we could have a "unchecked" / "unset" state

0 commit comments

Comments
 (0)