Skip to content

Commit 67ff2e4

Browse files
committed
Further cleanups regarding the unused doc profile
1 parent 864951e commit 67ff2e4

File tree

1 file changed

+5
-14
lines changed

1 file changed

+5
-14
lines changed

text/0000-named-custom-cargo-profiles.md

Lines changed: 5 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
B
12
- Feature Name: `custom_named_cargo_profiles`
23
- Start Date: 2019-04-04
34
- RFC PR: (leave this empty)
@@ -71,8 +72,6 @@ This also affects other Cargo commands:
7172
the predefined `test` profile which is described below.
7273
* `cargo bench` also receives `--profile`, but unless it is specified, uses
7374
the predefined `bench` profile which is described below.
74-
* `cargo doc` also receives `--profile`, but unless it is specified, uses
75-
the predefined `doc` profile which is described below.
7675

7776
## Effect over the use of profile in commands
7877

@@ -137,14 +136,6 @@ inherits = "dev"
137136
dir-name = "debug"
138137
```
139138

140-
* The `doc` profile defaults to the following definition, to preserve current
141-
behavior:
142-
```
143-
[profile.doc]
144-
inherits = "dev"
145-
dir-name = "debug"
146-
```
147-
148139
* The (upcoming) `build` profile defaults to the following definition:
149140

150141
```
@@ -175,9 +166,9 @@ implementation will replace it with a value of type `enum Profile {Dev,
175166
Release, Custom(String))`.
176167

177168
* The `Profiles` struct in `cargo/core/profiles.rs` currently has hardcoded
178-
`dev`, `release`, `test`, `bench`, and `doc` fields. This should be changed
179-
into a `BTreeMap` based on profile names. The pre-defined profiles can be
180-
loaded into it, before `TomlProfile` overrides are applied to them.
169+
`dev`, `release`, `test`, `bench`. This should be changed into a `BTreeMap`
170+
based on profile names. The pre-defined profiles can be loaded into it,
171+
before `TomlProfile` overrides are applied to them.
181172
* Similarly, `TomlProfiles` will be changed to hold profiles in a `BTreeMap`.
182173
* We would need to compute the actual `build_override` for a profile based on
183174
resolution through the `inherits` key.
@@ -255,7 +246,7 @@ For example:
255246
* Profile names would collide with rustc target names under `target/`. Should
256247
the output directory be also under a different namespace, e.g.
257248
`target/custom/release-lto`?
258-
* Do we really need pre-defined profiles for `test`, `bench` and/or `doc`, or
249+
* Do we really need pre-defined profiles for `test`, `bench`, or
259250
can we make them obsolete?
260251
* Is it worthwhile keeping `test` and `bench` outputs in `target/debug` and
261252
`target/release`? Doing so would save compilation time and space.

0 commit comments

Comments
 (0)