|
| 1 | +B |
1 | 2 | - Feature Name: `custom_named_cargo_profiles`
|
2 | 3 | - Start Date: 2019-04-04
|
3 | 4 | - RFC PR: (leave this empty)
|
@@ -71,8 +72,6 @@ This also affects other Cargo commands:
|
71 | 72 | the predefined `test` profile which is described below.
|
72 | 73 | * `cargo bench` also receives `--profile`, but unless it is specified, uses
|
73 | 74 | the predefined `bench` profile which is described below.
|
74 |
| -* `cargo doc` also receives `--profile`, but unless it is specified, uses |
75 |
| - the predefined `doc` profile which is described below. |
76 | 75 |
|
77 | 76 | ## Effect over the use of profile in commands
|
78 | 77 |
|
@@ -137,14 +136,6 @@ inherits = "dev"
|
137 | 136 | dir-name = "debug"
|
138 | 137 | ```
|
139 | 138 |
|
140 |
| -* The `doc` profile defaults to the following definition, to preserve current |
141 |
| - behavior: |
142 |
| -``` |
143 |
| -[profile.doc] |
144 |
| -inherits = "dev" |
145 |
| -dir-name = "debug" |
146 |
| -``` |
147 |
| - |
148 | 139 | * The (upcoming) `build` profile defaults to the following definition:
|
149 | 140 |
|
150 | 141 | ```
|
@@ -175,9 +166,9 @@ implementation will replace it with a value of type `enum Profile {Dev,
|
175 | 166 | Release, Custom(String))`.
|
176 | 167 |
|
177 | 168 | * The `Profiles` struct in `cargo/core/profiles.rs` currently has hardcoded
|
178 |
| - `dev`, `release`, `test`, `bench`, and `doc` fields. This should be changed |
179 |
| - into a `BTreeMap` based on profile names. The pre-defined profiles can be |
180 |
| - loaded into it, before `TomlProfile` overrides are applied to them. |
| 169 | + `dev`, `release`, `test`, `bench`. This should be changed into a `BTreeMap` |
| 170 | + based on profile names. The pre-defined profiles can be loaded into it, |
| 171 | + before `TomlProfile` overrides are applied to them. |
181 | 172 | * Similarly, `TomlProfiles` will be changed to hold profiles in a `BTreeMap`.
|
182 | 173 | * We would need to compute the actual `build_override` for a profile based on
|
183 | 174 | resolution through the `inherits` key.
|
@@ -255,7 +246,7 @@ For example:
|
255 | 246 | * Profile names would collide with rustc target names under `target/`. Should
|
256 | 247 | the output directory be also under a different namespace, e.g.
|
257 | 248 | `target/custom/release-lto`?
|
258 |
| -* Do we really need pre-defined profiles for `test`, `bench` and/or `doc`, or |
| 249 | +* Do we really need pre-defined profiles for `test`, `bench`, or |
259 | 250 | can we make them obsolete?
|
260 | 251 | * Is it worthwhile keeping `test` and `bench` outputs in `target/debug` and
|
261 | 252 | `target/release`? Doing so would save compilation time and space.
|
|
0 commit comments