Skip to content

Commit 4741ef8

Browse files
committed
Minor changes
1 parent 6e97b1a commit 4741ef8

File tree

3 files changed

+17
-11
lines changed

3 files changed

+17
-11
lines changed

README.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,9 @@ and the RFC seems to be in a steady state, the shepherd and/or sub-team leader
199199
will announce an FCP. In general, the idea here is to "front-load" as much of
200200
the feedback as possible before the point where we actually reach a decision -
201201
by the end of the FCP, the decision on whether or not to accept the RFC should
202-
be obvious from the RFC discussion thread.
202+
usually be obvious from the RFC discussion thread. On occasion, there may not be
203+
consensus but discussion has stalled. In this case, the relevant team will make
204+
a decision.
203205

204206

205207
## The RFC life-cycle
@@ -248,9 +250,9 @@ posted back to the RFC pull request.
248250
A sub-team makes final decisions about RFCs after the benefits and drawbacks are
249251
well understood. These decisions can be made at any time, but the sub-team will
250252
regularly issue decisions. When a decision is made, the RFC PR will either be
251-
merged or closed, in either case with a comment describing the rationale for the
252-
decision. The comment should largely be a summary of discussion already on the
253-
comment thread.
253+
merged or closed. In either case, if the reasoning is not clear from the
254+
discussion in thread, the sub-team will add a comment describing the rationale
255+
for the decision.
254256

255257

256258
## Implementing an RFC

compiler_changes.md

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,12 @@ submitted later if there is scope for large changes to the language RFC.
2626
non-trivial ways
2727
* Adding, removing, or changing a stable compiler flag
2828
* The implementation of new language features where there is significant change
29-
or addition to the compiler
29+
or addition to the compiler. There is obviously some room for interpretation
30+
about what consitutes a "significant" change and how much detail the
31+
implementation RFC needs. For guidance, [associated items](text/0195-associated-items.md)
32+
and [UFCS](text/0132-ufcs.md) would clearly need an implementation RFC,
33+
[type ascription](text/0803-type-ascription.md) and
34+
[lifetime elision](text/0141-lifetime-elision.md) would not.
3035
* Any other change which causes backwards incompatible changes to stable
3136
behaviour of the compiler, language, or libraries
3237

libs_changes.md

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@
2727
at this point in time can still mean major community breakage regardless of trains,
2828
however.
2929
* HOWEVER: Big PRs can be a lot of work to make only to have that work rejected for
30-
details that could have been hashed out first. *This is the motivation for
31-
having RFCs*.
30+
details that could have been hashed out first.
3231

3332
* RFCs are *only* meaningful if a significant and diverse portion of the
3433
community actively participates in them. The official teams are not
@@ -95,10 +94,10 @@ current implementation.
9594
* Once something has been merged as unstable, a shepherd should be assigned
9695
to promote and obtain feedback on the design.
9796

98-
* Once the API has been unstable for at least one full cycle (6 weeks),
99-
the shepherd (or any library sub-team member) may nominate an API for a
100-
*final comment period* of another cycle. Feedback and other comments should be
101-
posted to the tracking issue. This should be publicized.
97+
* Every time a release cycle ends, the libs teams assesses the current unstable
98+
APIs and selects some number of them for potential stabilization during the
99+
next cycle. These are announced for FCP at the beginning of the cycle, and
100+
(possibly) stabilized just before the beta is cut.
102101

103102
* After the final comment period, an API should ideally take one of two paths:
104103
* **Stabilize** if the change is desired, and consensus is reached

0 commit comments

Comments
 (0)