|
| 1 | +# PEH 2020-11-09 Meeting Agenda |
| 2 | + |
| 3 | +###### tags: `Error Handling` `Minutes` |
| 4 | + |
| 5 | +- [2020-10-26 Meeting Minutes](https://hackmd.io/@rust-libs/rJ6aitNOw) |
| 6 | + |
| 7 | +## Action Items |
| 8 | + |
| 9 | +- Implement trait based proof of concept for `Backtrace` in `core` (Jane Lusby) |
| 10 | +- Update `object-provider` API in generic member access RFC (Jane Lusby) |
| 11 | +- Move forward with adding an Error impl for `&impl Error` (Ashley Mannix) |
| 12 | + - Create an FCP on the existing PR |
| 13 | + - Add guidance for using &dyn Error + 'static and impl Error + Send + Sync + |
| 14 | + 'static for borrow and owned errors respectively |
| 15 | +- Review the "Fix the error trait" tracking issue to figure out next steps |
| 16 | + (Oliver + Ashley Mannix) |
| 17 | +- Review the panic plan rfc (Jane Lusby) |
| 18 | +- reach out to the author of the error codes issue (Jane Lusby) |
| 19 | +- Discuss universally consistent error reporting (Jane Lusby, Jakub Duchniewicz, |
| 20 | + and Jeremiah Senkpiel) |
| 21 | +- Post long term plan blog post (Sean Chean & Jane Lusby) |
| 22 | +- Begin writing chapters for The Rust Error Book (unassigned) |
| 23 | +- Resolve blockers in the backtrace stabilizition PR (Ashley Mannix) |
| 24 | + |
| 25 | +## Agenda Items |
| 26 | + |
| 27 | +- Review action items from last meeting |
| 28 | +- Review tracked issues in our [Project Board](https://github.com/rust-lang/project-error-handling/projects/1) |
| 29 | + - [RFC#2580 related to 'Stabilizing `Error::type_id`'](https://hackmd.io/1Fq9TcAQRWa4_weWTe9adA) |
| 30 | +- Anything to bubble up to the Libs meeting? |
| 31 | +- Review `The Rust Error Book` looking to add initial content |
| 32 | +- 2021 Rust Edition |
| 33 | + - postponed? |
| 34 | +- Discuss meeting time |
| 35 | + |
| 36 | +# Meeting Minutes |
| 37 | + |
| 38 | +Called to order at 13:00 PST |
| 39 | + |
| 40 | +## Attendees |
| 41 | + |
| 42 | +- Jane Lusby |
| 43 | +- Sean Chen |
| 44 | +- Oliver |
| 45 | +- Ashley Mannix |
| 46 | +- Mara |
| 47 | +- Jakub Duchniewicz |
| 48 | +- DPC |
| 49 | + |
| 50 | +## Progress on Backtrace in Core [Jane Lusby] |
| 51 | +- No progress on this since last time |
| 52 | + |
| 53 | +## Update Generic Member Access API [Jane Lusby] |
| 54 | +- Reviewed changes made by Nika |
| 55 | +- We should be using rustc errors as an example in the RFC |
| 56 | +- Universal reporting is still messy and depends on features that don't exist |
| 57 | + yet |
| 58 | +- RFC for this is basically complete with some pending updates including |
| 59 | + examples related to compiler error reporting |
| 60 | + |
| 61 | +## Adding an Error impl for `&impl Error` [Ashley Mannix] |
| 62 | +- In final comment period. Will go in 1.49.0 when it's ready to go. |
| 63 | +- starting patching for related libraries |
| 64 | + |
| 65 | +## Review the “Fix the error trait” tracking issue [Oliver + Ashley Mannix] |
| 66 | +- No progress on this |
| 67 | + |
| 68 | +## Review the panic plan rfc [Jane Lusby] |
| 69 | +- Now waiting for the FCP checkboxes; four more to go |
| 70 | + |
| 71 | +## Reach out to the author of the error codes issue [Jane Lusby] |
| 72 | +- Didn't get to this |
| 73 | + |
| 74 | +## Post long term plan blog post [Sean Chean & Jane Lusby] |
| 75 | +- Haven't put in suggested changes yet. |
| 76 | + |
| 77 | +## Begin writing chapters for The Rust Error Book [unassigned] |
| 78 | +- Put out a call for a collection of references |
| 79 | +- Are we targeting 2021 edition? |
| 80 | + - Not particularly; shouldn't have any major breaking changes |
| 81 | + - Besides unifying `panic`, shouldn't have anything that interacts with |
| 82 | + editions |
| 83 | + - Universal error reporting _might_ become something that involves requiring |
| 84 | + a breaking change, but too nebulous to know at the moment |
| 85 | + |
| 86 | + |
| 87 | +## Resolve blockers in the backtrace stabilizition PR [Ashley Mannix] |
| 88 | +- Different implementions for panics and errors since the panic backtrace |
| 89 | + resolver can resolve frames in the presence of memory errors. |
| 90 | +- Code between the two implementations can be shared, though this probably |
| 91 | + doesn't have implications on the API. |
| 92 | +- Unlisted concern in FCP |
| 93 | + - Blocked on Amanieu having time to look through the recent discussion to |
| 94 | + mark concern as resolved |
| 95 | + |
| 96 | +## Discuss universally consistent error reporting [Jane Lusby, Jakub Duchniewicz, and Jeremiah Senkpiel] |
| 97 | +- Trying to find a way to introduce a "Reporter" that handles displaying `E: |
| 98 | + Error` objects and additionally captures context relevant to those errors. |
| 99 | +- Maybe extend this type to also handle `PanicInfo` objects |
| 100 | + - Should naturally fit the design of the Error trait |
| 101 | + - `PanicInfo` already has this handled by the hook from `set_hook` |
| 102 | + - Unification will be a challenge |
| 103 | + |
| 104 | +## Backtrace Frames Method [Sean Chen] |
| 105 | +- Started on this, though need to continue working through details from @KodrAus |
| 106 | +- Suggestion to use a wrapper to return a borrow to data behind a `Mutex` |
| 107 | + - @KodrAus -- for safety should materialize a `Vec` behind a wrapper |
| 108 | + - additional suggestions forthcoming |
| 109 | + |
| 110 | +## Nicer Assert Messages [Charles Ellis O'Riley Jr.] |
| 111 | +- Charles not in attendance today; punt this to next meeting |
| 112 | + |
| 113 | +## `PanicInfo::message` RFC [DPC] |
| 114 | +- `de-vri-es` doing some work related to this |
| 115 | +- Trying to add some kind of `AssertionInfo` to a `PanicInfo` that the test |
| 116 | + crate can use to displays things more nicely without requiring support for |
| 117 | + colors in std |
| 118 | + |
| 119 | +## `Error::type_id` [unassigned] |
| 120 | +- Should enable a way to have function specialization such that `type_id` would |
| 121 | + be specialized for every type |
| 122 | +- Priority: low |
| 123 | + |
| 124 | +## Changing the Meeting Time going forward |
| 125 | +- SIMD meeting starts right after this one |
| 126 | +- Ideally, shift meeting back an hour for Daylight Savings and call it a day |
| 127 | +- If not, might have to do another poll for meeting times |
| 128 | +- Brought up in last week's SIMD meeting; didn't seem like anybody have issues |
| 129 | + with shifting it |
| 130 | + |
| 131 | +# Todo |
| 132 | +## Blog post coming soon |
| 133 | +- goals to be run by project group before starting something on internals |
| 134 | + |
| 135 | +## Update Object Provider API [Jane Lusby] |
| 136 | +- Add Nika's changes to RFC @2aetCAHHS5yPrDQIgqGo2Q |
| 137 | + |
| 138 | +## Adding an Error impl for `&impl Error` [Ashley Mannix] |
| 139 | +- We can start patching libraries that it will break to get it ready for 1.49.0 |
| 140 | + @KodrAus |
| 141 | + |
| 142 | +## Discuss universally consistent error reporting [Jane Lusby, Jakub Duchniewicz, and Jeremiah Senkpiel] |
| 143 | +- Draft a blog post laying this out @2aetCAHHS5yPrDQIgqGo2Q |
| 144 | + |
| 145 | +## Review "The Rust Error Book" to add additional content |
| 146 | +- Create an issue and gather existing resources to use as references for the |
| 147 | + book @2aetCAHHS5yPrDQIgqGo2Q |
| 148 | + |
| 149 | +## Resolve blockers in the backtrace stabilizition PR [Ashley Mannix] |
| 150 | +- Reach out to Amanieu to get their concerns resolved @KodrAus |
0 commit comments