Fix more Clippy lints

Author: GabrielMajeri

examples/aobench/src/intersection/ray_plane.rs

@@ -53,7 +53,8 @@ impl Intersect<Plane> for RayxN {
             }
         }
 
-        debug_assert!({
+        #[cfg(debug_assertions)]
+        {
             // Check that the vector and the scalar version produce the same results
             // for the same inputs in debug builds
             for i in 0..f32xN::lanes() {
@@ -62,8 +63,7 @@ impl Intersect<Plane> for RayxN {
                 let isect_i = ray_i.intersect(plane, old_isect_i);
                 assert!(isect_i.almost_eq(&isect.get(i)), "{:?} !~= {:?}\n\nplane: {:?}\n\nold_isect: {:?}\n\nrays: {:?}\n\ni: {:?}\nold_isect_i: {:?}\nray_i: {:?}\n\n", isect_i, isect.get(i), plane, old_isect, self, i, old_isect_i, ray_i);
             }
-            true
-        });
+        }
 
         isect
     }

examples/aobench/src/intersection/ray_sphere.rs

@@ -59,7 +59,8 @@ impl Intersect<Sphere> for RayxN {
             }
         }
 
-        debug_assert!({
+        #[cfg(debug_assertions)]
+        {
             // Check that the vector and the scalar version produce the same results
             // for the same inputs in debug builds
             for i in 0..f32xN::lanes() {
@@ -68,8 +69,7 @@ impl Intersect<Sphere> for RayxN {
                 let isect_i = ray_i.intersect(sphere, old_isect_i);
                 assert!(isect_i.almost_eq(&isect.get(i)), "{:?} !~= {:?}\n\nsphere: {:?}\n\nold_isect: {:?}\n\nrays: {:?}\n\ni: {:?}\nold_isect_i: {:?}\nray_i: {:?}\n\n", isect_i, isect.get(i), sphere, old_isect, self, i, old_isect_i, ray_i);
             }
-            true
-        });
+        }
 
         isect
     }

examples/aobench/src/lib.rs

@@ -12,7 +12,8 @@
     clippy::cast_possible_truncation,
     clippy::cast_sign_loss,
     clippy::identity_op,
-    clippy::erasing_op
+    clippy::erasing_op,
+    clippy::must_use_candidate
 )]
 
 pub mod ambient_occlusion;

examples/dot_product/src/lib.rs

@@ -1,6 +1,7 @@
 //! Vector dot product
 #![deny(warnings, rust_2018_idioms)]
 #![feature(custom_inner_attributes)]
+#![allow(clippy::must_use_candidate)]
 
 pub mod scalar;
 pub mod simd;

examples/fannkuch_redux/src/lib.rs

@@ -6,7 +6,8 @@
     clippy::many_single_char_names,
     clippy::cast_possible_truncation,
     clippy::cast_sign_loss,
-    clippy::cast_possible_wrap
+    clippy::cast_possible_wrap,
+    clippy::must_use_candidate
 )]
 
 pub mod scalar;

examples/mandelbrot/src/lib.rs

@@ -6,7 +6,8 @@
 #![allow(
     clippy::cast_precision_loss,
     clippy::cast_sign_loss,
-    clippy::cast_possible_truncation
+    clippy::cast_possible_truncation,
+    clippy::must_use_candidate
 )]
 
 use rayon::prelude::*;

examples/mandelbrot/src/simd_par.rs

@@ -145,10 +145,11 @@ pub fn generate(dims: Dimensions, xr: Range, yr: Range) -> Vec<u32> {
         });
     });
 
+    // This is safe, we're transmuting from a more-aligned type to a
+    // less-aligned one.
+    #[allow(clippy::unsound_collection_transmute)]
     unsafe {
         let mut out: Vec<u32> = std::mem::transmute(out);
-        // This is safe, we're transmuting from a more-aligned type to a
-        // less-aligned one.
         out.set_len(width * height);
         out
     }

examples/matrix_inverse/src/lib.rs

@@ -1,6 +1,7 @@
 //! 4x4 matrix inverse
 #![feature(custom_inner_attributes)]
 #![deny(warnings, rust_2018_idioms)]
+#![allow(clippy::must_use_candidate)]
 
 pub mod scalar;
 pub mod simd;

examples/nbody/src/lib.rs

@@ -2,7 +2,11 @@
 //!
 //! [bg]: https://benchmarksgame-team.pages.debian.net/benchmarksgame/description/nbody.html#nbody
 #![deny(warnings, rust_2018_idioms)]
-#![allow(clippy::similar_names, clippy::excessive_precision)]
+#![allow(
+    clippy::similar_names,
+    clippy::excessive_precision,
+    clippy::must_use_candidate
+)]
 
 pub mod scalar;
 pub mod simd;

examples/options_pricing/src/lib.rs

@@ -6,6 +6,7 @@
     clippy::cast_precision_loss,
     clippy::cast_possible_truncation,
     clippy::cast_possible_wrap,
+    clippy::must_use_candidate,
     clippy::too_many_arguments
 )]
 

examples/spectral_norm/src/lib.rs

@@ -1,7 +1,10 @@
 //! Spectral Norm
 #![deny(warnings, rust_2018_idioms)]
 #![allow(non_snake_case, non_camel_case_types)]
-#![allow(clippy::cast_precision_loss)]
+#![allow(
+    clippy::cast_precision_loss,
+    clippy::must_use_candidate
+)]
 
 pub mod scalar;
 pub mod simd;

examples/stencil/src/lib.rs

@@ -7,7 +7,8 @@
     clippy::too_many_arguments,
     clippy::cast_possible_wrap,
     clippy::cast_possible_truncation,
-    clippy::inline_always
+    clippy::inline_always,
+    clippy::must_use_candidate
 )]
 
 #[cfg(feature = "ispc")]

examples/triangle_xform/src/lib.rs

@@ -1,3 +1,5 @@
+#![allow(clippy::must_use_candidate)]
+
 /// Simple matrix type.
 /// The memory layout is the same as the one for Direct3D/OpenGL: fourth vector
 /// represents the translation vector `[x, y, z]`.

src/api/minimal/ptr.rs

@@ -68,7 +68,7 @@ macro_rules! impl_minimal_p {
 
             /// Extracts the value at `index`.
             ///
-            /// # Precondition
+            /// # Safety
             ///
             /// If `index >= Self::lanes()` the behavior is undefined.
             #[inline]
@@ -96,7 +96,7 @@ macro_rules! impl_minimal_p {
 
             /// Returns a new vector where the value at `index` is replaced by `new_value`.
             ///
-            /// # Precondition
+            /// # Safety
             ///
             /// If `index >= Self::lanes()` the behavior is undefined.
             #[inline]
@@ -611,7 +611,7 @@ macro_rules! impl_minimal_p {
 
             /// Instantiates a new vector with the values of the `slice`.
             ///
-            /// # Precondition
+            /// # Safety
             ///
             /// If `slice.len() < Self::lanes()` or `&slice[0]` is not aligned
             /// to an `align_of::<Self>()` boundary, the behavior is undefined.
@@ -624,7 +624,7 @@ macro_rules! impl_minimal_p {
 
             /// Instantiates a new vector with the values of the `slice`.
             ///
-            /// # Precondition
+            /// # Safety
             ///
             /// If `slice.len() < Self::lanes()` the behavior is undefined.
             #[inline]
@@ -827,7 +827,7 @@ macro_rules! impl_minimal_p {
 
             /// Writes the values of the vector to the `slice`.
             ///
-            /// # Precondition
+            /// # Safety
             ///
             /// If `slice.len() < Self::lanes()` or `&slice[0]` is not
             /// aligned to an `align_of::<Self>()` boundary, the behavior is
@@ -843,7 +843,7 @@ macro_rules! impl_minimal_p {
 
             /// Writes the values of the vector to the `slice`.
             ///
-            /// # Precondition
+            /// # Safety
             ///
             /// If `slice.len() < Self::lanes()` the behavior is undefined.
             #[inline]
@@ -1151,7 +1151,7 @@ macro_rules! impl_minimal_p {
             /// As such, memory acquired directly from allocators or memory
             /// mapped files may be too large to handle with this function.
             ///
-            /// Consider using wrapping_offset_from instead if these constraints
+            /// Consider using `wrapping_offset_from` instead if these constraints
             /// are difficult to satisfy. The only advantage of this method is
             /// that it enables more aggressive compiler optimizations.
             #[inline]

src/lib.rs

@@ -218,6 +218,8 @@
          clippy::cast_lossless,
          clippy::cast_possible_wrap,
          clippy::cast_precision_loss,
+         // TODO: manually add the `#[must_use]` attribute where appropiate
+         clippy::must_use_candidate,
          // This lint is currently broken for generic code
          // See https://github.com/rust-lang/rust-clippy/issues/3410
          clippy::use_self,