Skip to content

Commit f9dd115

Browse files
committed
Auto merge of #847 - RalfJung:rustup, r=RalfJung
fix for rustc_driver change
2 parents fe60759 + 11d7119 commit f9dd115

File tree

4 files changed

+14
-15
lines changed

4 files changed

+14
-15
lines changed

benches/helpers/miri_helper.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@ extern crate test;
88
use self::miri::eval_main;
99
use rustc::hir::def_id::LOCAL_CRATE;
1010
use rustc_interface::interface;
11+
use rustc_driver::Compilation;
1112
use crate::test::Bencher;
1213

1314
struct MiriCompilerCalls<'a> {
1415
bencher: &'a mut Bencher,
1516
}
1617

1718
impl rustc_driver::Callbacks for MiriCompilerCalls<'_> {
18-
fn after_analysis(&mut self, compiler: &interface::Compiler) -> bool {
19+
fn after_analysis(&mut self, compiler: &interface::Compiler) -> Compilation {
1920
compiler.session().abort_if_errors();
2021

2122
compiler.global_ctxt().unwrap().peek_mut().enter(|tcx| {
@@ -31,8 +32,7 @@ impl rustc_driver::Callbacks for MiriCompilerCalls<'_> {
3132

3233
compiler.session().abort_if_errors();
3334

34-
// Don't continue execution
35-
false
35+
Compilation::Stop
3636
}
3737
}
3838

rust-version

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
d36b7f69448f7390fa9dfde75d58b914365acdab
1+
527dce7137f7a3c7bf47d9a503abf25f88ea22de

src/bin/miri-rustc-tests.rs

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ use rustc_interface::interface;
1919
use rustc::hir::{self, itemlikevisit};
2020
use rustc::ty::TyCtxt;
2121
use rustc::hir::def_id::LOCAL_CRATE;
22+
use rustc_driver::Compilation;
2223

2324
use miri::MiriConfig;
2425

@@ -28,18 +29,17 @@ struct MiriCompilerCalls {
2829
}
2930

3031
impl rustc_driver::Callbacks for MiriCompilerCalls {
31-
fn after_parsing(&mut self, compiler: &interface::Compiler) -> bool {
32+
fn after_parsing(&mut self, compiler: &interface::Compiler) -> Compilation {
3233
let attr = (
3334
syntax::symbol::Symbol::intern("miri"),
3435
syntax::feature_gate::AttributeType::Whitelisted,
3536
);
3637
compiler.session().plugin_attributes.borrow_mut().push(attr);
3738

38-
// Continue execution
39-
true
39+
Compilation::Continue
4040
}
4141

42-
fn after_analysis(&mut self, compiler: &interface::Compiler) -> bool {
42+
fn after_analysis(&mut self, compiler: &interface::Compiler) -> Compilation {
4343
compiler.session().abort_if_errors();
4444
compiler.global_ctxt().unwrap().peek_mut().enter(|tcx| {
4545
if std::env::args().any(|arg| arg == "--test") {
@@ -71,7 +71,7 @@ impl rustc_driver::Callbacks for MiriCompilerCalls {
7171
});
7272

7373
// Continue execution on host target
74-
self.host_target
74+
if self.host_target { Compilation::Continue } else { Compilation::Stop }
7575
}
7676
}
7777

src/bin/miri.rs

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,24 +21,24 @@ use hex::FromHexError;
2121

2222
use rustc_interface::interface;
2323
use rustc::hir::def_id::LOCAL_CRATE;
24+
use rustc_driver::Compilation;
2425

2526
struct MiriCompilerCalls {
2627
miri_config: miri::MiriConfig,
2728
}
2829

2930
impl rustc_driver::Callbacks for MiriCompilerCalls {
30-
fn after_parsing(&mut self, compiler: &interface::Compiler) -> bool {
31+
fn after_parsing(&mut self, compiler: &interface::Compiler) -> Compilation {
3132
let attr = (
3233
syntax::symbol::Symbol::intern("miri"),
3334
syntax::feature_gate::AttributeType::Whitelisted,
3435
);
3536
compiler.session().plugin_attributes.borrow_mut().push(attr);
3637

37-
// Continue execution
38-
true
38+
Compilation::Continue
3939
}
4040

41-
fn after_analysis(&mut self, compiler: &interface::Compiler) -> bool {
41+
fn after_analysis(&mut self, compiler: &interface::Compiler) -> Compilation {
4242
init_late_loggers();
4343
compiler.session().abort_if_errors();
4444

@@ -54,8 +54,7 @@ impl rustc_driver::Callbacks for MiriCompilerCalls {
5454

5555
compiler.session().abort_if_errors();
5656

57-
// Don't continue execution
58-
false
57+
Compilation::Stop
5958
}
6059
}
6160

0 commit comments

Comments
 (0)