Skip to content

Commit 990b04e

Browse files
committed
add comment mentioning alternative approach
1 parent 9f6569c commit 990b04e

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

cargo-miri/bin.rs

+5
Original file line numberDiff line numberDiff line change
@@ -394,6 +394,11 @@ fn phase_cargo_miri(mut args: env::Args) {
394394
setup(subcommand);
395395

396396
// Invoke actual cargo for the job, but with different flags.
397+
// We re-use `cargo test` and `cargo run`, which makes target and binary handling very easy but
398+
// requires some extra work to make the build check-only (see all the `--emit` hacks below).
399+
// <https://github.com/rust-lang/miri/pull/1540#issuecomment-693553191> describes an alternative
400+
// approach that uses `cargo check`, making that part easier but target and binary handling
401+
// harder.
397402
let miri_path = std::env::current_exe().expect("current executable path invalid");
398403
let cargo_cmd = match subcommand {
399404
MiriCommand::Test => "test",

0 commit comments

Comments
 (0)