Skip to content

Implement standard traits on C-unwind ABI function pointers #100

Closed
@lopopolo

Description

@lopopolo

Proposal

Implement the standard set of core traits on C-unwind ABI function pointers:

Problem statement

I would like to stabilize RFC rust-lang/rfcs#2945 which has tracking Issue rust-lang/rust#74990. Implementing common traits like fmt::Debug on these function pointers is blocking stabilization of the c_unwind feature.

Motivation, use-cases

The lack of common traits like fmt::Debug on C-unwind ABI function pointers prevents them from being used with common tools like bindgen.

Solution sketches

rust-lang/rust#101263 has been filed and signed off on by the compiler team.

Links and related work

What happens now?

This issue is part of the libs-api team API change proposal process. Once this issue is filed the libs-api team will review open proposals in its weekly meeting. You should receive feedback within a week or two.

Activity

lopopolo

lopopolo commented on Sep 10, 2022

@lopopolo
Author

I was asked to file this ACP by @thomcc here: rust-lang/rust#101263 (comment).

lopopolo

lopopolo commented on Oct 7, 2022

@lopopolo
Author

Hi folks, checking in on this ACP since its been about 4 weeks since I opened it and the rustc dev guide and ticket template hinted that this would be looked at within a week or two.

This ACP is (I think) blocking the addition of some fmt traits as part of an already accepted RFC. Is there a part of the process I've missed?

I'm still not quite sure why this change (which is part of a larger, already-approved RFC) is blocked on an ACP. It looks like some API changes, like rust-lang/rust#101308, can make it to nightly without one.

@joshtriplett is this ACP something you can help me get some eyes on? (I saw you approved the new API addition I linked)

lopopolo

lopopolo commented on Oct 21, 2022

@lopopolo
Author

rust-lang/rust#101263 is approved and in the bors queue, which I think means this ACP is not required anymore.

added
ACP-acceptedAPI Change Proposal is accepted (seconded with no objections)
on Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    ACP-acceptedAPI Change Proposal is accepted (seconded with no objections)T-libs-apiapi-change-proposalA proposal to add or alter unstable APIs in the standard libraries

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @lopopolo@dtolnay

        Issue actions

          Implement standard traits on `C-unwind` ABI function pointers · Issue #100 · rust-lang/libs-team