Skip to content

Commit f05d6a3

Browse files
committed
Auto merge of #3489 - JohnTitor:i686-pc-windows-gnu-ci, r=JohnTitor
Re-enable `i686-pc-windows-gnu` CI Let's see if GCC doesn't crash anymore. Fixes #1592
2 parents bb4eae6 + d8b4bb5 commit f05d6a3

File tree

3 files changed

+16
-13
lines changed

3 files changed

+16
-13
lines changed

.github/workflows/bors.yml

+4-6
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,10 @@ jobs:
7373
ARCH_BITS: 64
7474
ARCH: x86_64
7575
- target: x86_64-pc-windows-msvc
76-
# Disabled because broken:
77-
# https://github.com/rust-lang/libc/issues/1592
78-
#- target: i686-pc-windows-gnu
79-
# env:
80-
# ARCH_BITS: 32
81-
# ARCH: i686
76+
- target: i686-pc-windows-gnu
77+
env:
78+
ARCH_BITS: 32
79+
ARCH: i686
8280
- target: i686-pc-windows-msvc
8381
steps:
8482
- uses: rust-lang/simpleinfra/github-actions/cancel-outdated-builds@HEAD

.github/workflows/main.yml

+4-6
Original file line numberDiff line numberDiff line change
@@ -58,12 +58,10 @@ jobs:
5858
ARCH_BITS: 64
5959
ARCH: x86_64
6060
- target: x86_64-pc-windows-msvc
61-
# Disabled because broken:
62-
# https://github.com/rust-lang/libc/issues/1592
63-
#- target: i686-pc-windows-gnu
64-
# env:
65-
# ARCH_BITS: 32
66-
# ARCH: i686
61+
- target: i686-pc-windows-gnu
62+
env:
63+
ARCH_BITS: 32
64+
ARCH: i686
6765
- target: i686-pc-windows-msvc
6866
steps:
6967
- uses: actions/checkout@v4

libc-test/build.rs

+8-1
Original file line numberDiff line numberDiff line change
@@ -618,6 +618,7 @@ fn test_openbsd(target: &str) {
618618
fn test_windows(target: &str) {
619619
assert!(target.contains("windows"));
620620
let gnu = target.contains("gnu");
621+
let i686 = target.contains("i686");
621622

622623
let mut cfg = ctest_cfg();
623624
if target.contains("msvc") {
@@ -684,14 +685,20 @@ fn test_windows(target: &str) {
684685
cfg.skip_type(move |name| match name {
685686
"SSIZE_T" if !gnu => true,
686687
"ssize_t" if !gnu => true,
688+
// FIXME: The size and alignment of this type are incorrect
689+
"time_t" if gnu && i686 => true,
687690
_ => false,
688691
});
689692

690693
cfg.skip_struct(move |ty| {
691694
if ty.starts_with("__c_anonymous_") {
692695
return true;
693696
}
694-
return false;
697+
match ty {
698+
// FIXME: The size and alignment of this struct are incorrect
699+
"timespec" if gnu && i686 => true,
700+
_ => false,
701+
}
695702
});
696703

697704
cfg.skip_const(move |name| {

0 commit comments

Comments
 (0)