Skip to content

Commit 55d8d83

Browse files
tgross35tgross35
authored
Merge pull request #4230 from lvllvl/4117-part-2
Classify FIXMEs in repo - 2
2 parents 1f68d57 + 174a37c commit 55d8d83

File tree

9 files changed

+51
-51
lines changed

9 files changed

+51
-51
lines changed

‎src/unix/hurd/mod.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ pub type nl_item = c_int;
226226
pub type iconv_t = *mut c_void;
227227

228228
#[cfg_attr(feature = "extra_traits", derive(Debug))]
229-
pub enum fpos64_t {} // FIXME: fill this out with a struct
229+
pub enum fpos64_t {} // FIXME(hurd): fill this out with a struct
230230
impl Copy for fpos64_t {}
231231
impl Clone for fpos64_t {
232232
fn clone(&self) -> fpos64_t {
@@ -814,7 +814,7 @@ s! {
814814
pub ifa_flags: c_uint,
815815
pub ifa_addr: *mut crate::sockaddr,
816816
pub ifa_netmask: *mut crate::sockaddr,
817-
pub ifa_ifu: *mut crate::sockaddr, // FIXME This should be a union
817+
pub ifa_ifu: *mut crate::sockaddr, // FIXME(union) This should be a union
818818
pub ifa_data: *mut c_void,
819819
}
820820

@@ -1092,7 +1092,7 @@ cfg_if! {
10921092
.field("ut_line", &self.ut_line)
10931093
.field("ut_id", &self.ut_id)
10941094
.field("ut_user", &self.ut_user)
1095-
// FIXME: .field("ut_host", &self.ut_host)
1095+
// FIXME(debug): .field("ut_host", &self.ut_host)
10961096
.field("ut_exit", &self.ut_exit)
10971097
.field("ut_session", &self.ut_session)
10981098
.field("ut_tv", &self.ut_tv)

‎src/unix/linux_like/android/b32/x86/mod.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -281,11 +281,11 @@ pub const SYS_personality: c_long = 136;
281281
pub const SYS_afs_syscall: c_long = 137;
282282
pub const SYS_setfsuid: c_long = 138;
283283
pub const SYS_setfsgid: c_long = 139;
284-
// FIXME: SYS__llseek is in the NDK sources but for some reason is
284+
// FIXME(android): SYS__llseek is in the NDK sources but for some reason is
285285
// not available in the tests
286286
// pub const SYS__llseek: c_long = 140;
287287
pub const SYS_getdents: c_long = 141;
288-
// FIXME: SYS__newselect is in the NDK sources but for some reason is
288+
// FIXME(android): SYS__newselect is in the NDK sources but for some reason is
289289
// not available in the tests
290290
// pub const SYS__newselect: c_long = 142;
291291
pub const SYS_flock: c_long = 143;
@@ -294,7 +294,7 @@ pub const SYS_readv: c_long = 145;
294294
pub const SYS_writev: c_long = 146;
295295
pub const SYS_getsid: c_long = 147;
296296
pub const SYS_fdatasync: c_long = 148;
297-
// FIXME: SYS__llseek is in the NDK sources but for some reason is
297+
// FIXME(android): SYS__llseek is in the NDK sources but for some reason is
298298
// not available in the tests
299299
// pub const SYS__sysctl: c_long = 149;
300300
pub const SYS_mlock: c_long = 150;

‎src/unix/linux_like/android/b64/mod.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ cfg_if! {
161161
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
162162
f.debug_struct("pthread_mutex_t")
163163
.field("value", &self.value)
164-
// FIXME: .field("__reserved", &self.__reserved)
164+
// FIXME(debug): .field("__reserved", &self.__reserved)
165165
.finish()
166166
}
167167
}
@@ -190,7 +190,7 @@ cfg_if! {
190190
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
191191
f.debug_struct("pthread_cond_t")
192192
.field("value", &self.value)
193-
// FIXME: .field("__reserved", &self.__reserved)
193+
// FIXME(debug): .field("__reserved", &self.__reserved)
194194
.finish()
195195
}
196196
}
@@ -227,7 +227,7 @@ cfg_if! {
227227
.field("pendingReaders", &self.pendingReaders)
228228
.field("pendingWriters", &self.pendingWriters)
229229
.field("attr", &self.attr)
230-
// FIXME: .field("__reserved", &self.__reserved)
230+
// FIXME(debug): .field("__reserved", &self.__reserved)
231231
.finish()
232232
}
233233
}

‎src/unix/linux_like/android/b64/x86_64/mod.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -353,7 +353,7 @@ cfg_if! {
353353
.field("mxcsr", &self.mxcsr)
354354
.field("mxcr_mask", &self.mxcr_mask)
355355
.field("st_space", &self.st_space)
356-
// FIXME: .field("xmm_space", &self.xmm_space)
356+
// FIXME(debug): .field("xmm_space", &self.xmm_space)
357357
// Ignore padding field
358358
.finish()
359359
}
@@ -545,7 +545,7 @@ pub const SYS_munlockall: c_long = 152;
545545
pub const SYS_vhangup: c_long = 153;
546546
pub const SYS_modify_ldt: c_long = 154;
547547
pub const SYS_pivot_root: c_long = 155;
548-
// FIXME: SYS__sysctl is in the NDK sources but for some reason is
548+
// FIXME(android): SYS__sysctl is in the NDK sources but for some reason is
549549
// not available in the tests
550550
// pub const SYS__sysctl: c_long = 156;
551551
pub const SYS_prctl: c_long = 157;

‎src/unix/linux_like/android/mod.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -690,7 +690,7 @@ cfg_if! {
690690
.field("d_off", &self.d_off)
691691
.field("d_reclen", &self.d_reclen)
692692
.field("d_type", &self.d_type)
693-
// FIXME: .field("d_name", &self.d_name)
693+
// FIXME(debug): .field("d_name", &self.d_name)
694694
.finish()
695695
}
696696
}
@@ -728,7 +728,7 @@ cfg_if! {
728728
.field("d_off", &self.d_off)
729729
.field("d_reclen", &self.d_reclen)
730730
.field("d_type", &self.d_type)
731-
// FIXME: .field("d_name", &self.d_name)
731+
// FIXME(debug): .field("d_name", &self.d_name)
732732
.finish()
733733
}
734734
}
@@ -800,7 +800,7 @@ cfg_if! {
800800
f.debug_struct("lastlog")
801801
.field("ll_time", &self.ll_time)
802802
.field("ll_line", &self.ll_line)
803-
// FIXME: .field("ll_host", &self.ll_host)
803+
// FIXME(debug): .field("ll_host", &self.ll_host)
804804
.finish()
805805
}
806806
}
@@ -851,7 +851,7 @@ cfg_if! {
851851
.field("ut_line", &self.ut_line)
852852
.field("ut_id", &self.ut_id)
853853
.field("ut_user", &self.ut_user)
854-
// FIXME: .field("ut_host", &self.ut_host)
854+
// FIXME(debug): .field("ut_host", &self.ut_host)
855855
.field("ut_exit", &self.ut_exit)
856856
.field("ut_session", &self.ut_session)
857857
.field("ut_tv", &self.ut_tv)

‎src/unix/linux_like/emscripten/mod.rs

+4-4
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ pub type statvfs64 = crate::statvfs;
4444
pub type dirent64 = crate::dirent;
4545

4646
#[cfg_attr(feature = "extra_traits", derive(Debug))]
47-
pub enum fpos64_t {} // FIXME: fill this out with a struct
47+
pub enum fpos64_t {} // FIXME(emscripten): fill this out with a struct
4848
impl Copy for fpos64_t {}
4949
impl Clone for fpos64_t {
5050
fn clone(&self) -> fpos64_t {
@@ -412,7 +412,7 @@ cfg_if! {
412412
.field("d_off", &self.d_off)
413413
.field("d_reclen", &self.d_reclen)
414414
.field("d_type", &self.d_type)
415-
// FIXME: .field("d_name", &self.d_name)
415+
// FIXME(debug): .field("d_name", &self.d_name)
416416
.finish()
417417
}
418418
}
@@ -465,7 +465,7 @@ cfg_if! {
465465
.field("totalhigh", &self.totalhigh)
466466
.field("freehigh", &self.freehigh)
467467
.field("mem_unit", &self.mem_unit)
468-
// FIXME: .field("__reserved", &self.__reserved)
468+
// FIXME(debug): .field("__reserved", &self.__reserved)
469469
.finish()
470470
}
471471
}
@@ -525,7 +525,7 @@ cfg_if! {
525525
impl fmt::Debug for pthread_cond_t {
526526
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
527527
f.debug_struct("pthread_cond_t")
528-
// FIXME: .field("size", &self.size)
528+
// FIXME(debug): .field("size", &self.size)
529529
.finish()
530530
}
531531
}

‎src/unix/linux_like/mod.rs

+9-9
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,7 @@ s! {
166166
pub ifa_flags: c_uint,
167167
pub ifa_addr: *mut crate::sockaddr,
168168
pub ifa_netmask: *mut crate::sockaddr,
169-
pub ifa_ifu: *mut crate::sockaddr, // FIXME This should be a union
169+
pub ifa_ifu: *mut crate::sockaddr, // FIXME(union) This should be a union
170170
pub ifa_data: *mut c_void,
171171
}
172172

@@ -347,7 +347,7 @@ cfg_if! {
347347
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
348348
f.debug_struct("sockaddr_un")
349349
.field("sun_family", &self.sun_family)
350-
// FIXME: .field("sun_path", &self.sun_path)
350+
// FIXME(debug): .field("sun_path", &self.sun_path)
351351
.finish()
352352
}
353353
}
@@ -376,7 +376,7 @@ cfg_if! {
376376
f.debug_struct("sockaddr_storage")
377377
.field("ss_family", &self.ss_family)
378378
.field("__ss_align", &self.__ss_align)
379-
// FIXME: .field("__ss_pad2", &self.__ss_pad2)
379+
// FIXME(debug): .field("__ss_pad2", &self.__ss_pad2)
380380
.finish()
381381
}
382382
}
@@ -427,12 +427,12 @@ cfg_if! {
427427
impl fmt::Debug for utsname {
428428
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
429429
f.debug_struct("utsname")
430-
// FIXME: .field("sysname", &self.sysname)
431-
// FIXME: .field("nodename", &self.nodename)
432-
// FIXME: .field("release", &self.release)
433-
// FIXME: .field("version", &self.version)
434-
// FIXME: .field("machine", &self.machine)
435-
// FIXME: .field("domainname", &self.domainname)
430+
// FIXME(debug): .field("sysname", &self.sysname)
431+
// FIXME(debug): .field("nodename", &self.nodename)
432+
// FIXME(debug): .field("release", &self.release)
433+
// FIXME(debug): .field("version", &self.version)
434+
// FIXME(debug): .field("machine", &self.machine)
435+
// FIXME(debug): .field("domainname", &self.domainname)
436436
.finish()
437437
}
438438
}

‎src/unix/mod.rs

+8-8
Original file line numberDiff line numberDiff line change
@@ -538,7 +538,7 @@ missing! {
538538
#[cfg_attr(feature = "extra_traits", derive(Debug))]
539539
pub enum FILE {}
540540
#[cfg_attr(feature = "extra_traits", derive(Debug))]
541-
pub enum fpos_t {} // FIXME: fill this out with a struct
541+
pub enum fpos_t {} // FIXME(unix): fill this out with a struct
542542
}
543543

544544
extern "C" {
@@ -1325,11 +1325,11 @@ extern "C" {
13251325

13261326
#[cfg_attr(target_os = "netbsd", link_name = "__gmtime_r50")]
13271327
#[cfg_attr(any(target_env = "musl", target_env = "ohos"), allow(deprecated))]
1328-
// FIXME: for `time_t`
1328+
// FIXME(time): for `time_t`
13291329
pub fn gmtime_r(time_p: *const time_t, result: *mut tm) -> *mut tm;
13301330
#[cfg_attr(target_os = "netbsd", link_name = "__localtime_r50")]
13311331
#[cfg_attr(any(target_env = "musl", target_env = "ohos"), allow(deprecated))]
1332-
// FIXME: for `time_t`
1332+
// FIXME(time): for `time_t`
13331333
pub fn localtime_r(time_p: *const time_t, result: *mut tm) -> *mut tm;
13341334
#[cfg_attr(
13351335
all(target_os = "macos", target_arch = "x86"),
@@ -1345,19 +1345,19 @@ extern "C" {
13451345
pub fn time(time: *mut time_t) -> time_t;
13461346
#[cfg_attr(target_os = "netbsd", link_name = "__gmtime50")]
13471347
#[cfg_attr(any(target_env = "musl", target_env = "ohos"), allow(deprecated))]
1348-
// FIXME: for `time_t`
1348+
// FIXME(time): for `time_t`
13491349
pub fn gmtime(time_p: *const time_t) -> *mut tm;
13501350
#[cfg_attr(target_os = "netbsd", link_name = "__locatime50")]
13511351
#[cfg_attr(any(target_env = "musl", target_env = "ohos"), allow(deprecated))]
1352-
// FIXME: for `time_t`
1352+
// FIXME(time): for `time_t`
13531353
pub fn localtime(time_p: *const time_t) -> *mut tm;
13541354
#[cfg_attr(target_os = "netbsd", link_name = "__difftime50")]
13551355
#[cfg_attr(any(target_env = "musl", target_env = "ohos"), allow(deprecated))]
1356-
// FIXME: for `time_t`
1356+
// FIXME(time): for `time_t`
13571357
pub fn difftime(time1: time_t, time0: time_t) -> c_double;
13581358
#[cfg_attr(target_os = "netbsd", link_name = "__timegm50")]
13591359
#[cfg_attr(any(target_env = "musl", target_env = "ohos"), allow(deprecated))]
1360-
// FIXME: for `time_t`
1360+
// FIXME(time): for `time_t`
13611361
pub fn timegm(tm: *mut crate::tm) -> time_t;
13621362

13631363
#[cfg_attr(target_os = "netbsd", link_name = "__mknod50")]
@@ -1615,7 +1615,7 @@ cfg_if! {
16151615
all(target_os = "freebsd", any(freebsd11, freebsd10)),
16161616
link_name = "readdir_r@FBSD_1.0"
16171617
)]
1618-
#[allow(non_autolinks)] // FIXME: `<>` breaks line length limit.
1618+
#[allow(non_autolinks)] // FIXME(docs): `<>` breaks line length limit.
16191619
/// The 64-bit libc on Solaris and illumos only has readdir_r. If a
16201620
/// 32-bit Solaris or illumos target is ever created, it should use
16211621
/// __posix_readdir_r. See libc(3LIB) on Solaris or illumos:

‎src/unix/redox/mod.rs

+15-15
Original file line numberDiff line numberDiff line change
@@ -348,7 +348,7 @@ pub const F_LOCK: c_int = 1;
348348
pub const F_TLOCK: c_int = 2;
349349
pub const F_TEST: c_int = 3;
350350

351-
// FIXME: relibc {
351+
// FIXME(redox): relibc {
352352
pub const RTLD_DEFAULT: *mut c_void = 0i64 as *mut c_void;
353353
// }
354354

@@ -504,7 +504,7 @@ pub const F_GETFD: c_int = 1;
504504
pub const F_SETFD: c_int = 2;
505505
pub const F_GETFL: c_int = 3;
506506
pub const F_SETFL: c_int = 4;
507-
// FIXME: relibc {
507+
// FIXME(redox): relibc {
508508
pub const F_DUPFD_CLOEXEC: c_int = crate::F_DUPFD;
509509
// }
510510
pub const FD_CLOEXEC: c_int = 0x0100_0000;
@@ -526,7 +526,7 @@ pub const O_DIRECTORY: c_int = 0x1000_0000;
526526
pub const O_PATH: c_int = 0x2000_0000;
527527
pub const O_SYMLINK: c_int = 0x4000_0000;
528528
// Negative to allow it to be used as int
529-
// FIXME: Fix negative values missing from includes
529+
// FIXME(redox): Fix negative values missing from includes
530530
pub const O_NOFOLLOW: c_int = -0x8000_0000;
531531

532532
// locale.h
@@ -567,7 +567,7 @@ pub const NI_NAMEREQD: c_int = 0x0008;
567567
pub const NI_DGRAM: c_int = 0x0010;
568568

569569
// netinet/in.h
570-
// FIXME: relibc {
570+
// FIXME(redox): relibc {
571571
pub const IP_TTL: c_int = 2;
572572
pub const IPV6_UNICAST_HOPS: c_int = 16;
573573
pub const IPV6_MULTICAST_IF: c_int = 17;
@@ -592,7 +592,7 @@ pub const IPPROTO_MAX: c_int = 255;
592592

593593
// netinet/tcp.h
594594
pub const TCP_NODELAY: c_int = 1;
595-
// FIXME: relibc {
595+
// FIXME(redox): relibc {
596596
pub const TCP_KEEPIDLE: c_int = 1;
597597
// }
598598

@@ -723,7 +723,7 @@ pub const EXIT_SUCCESS: c_int = 0;
723723
pub const EXIT_FAILURE: c_int = 1;
724724

725725
// sys/ioctl.h
726-
// FIXME: relibc {
726+
// FIXME(redox): relibc {
727727
pub const FIONREAD: c_ulong = 0x541B;
728728
pub const FIONBIO: c_ulong = 0x5421;
729729
pub const FIOCLEX: c_ulong = 0x5451;
@@ -1283,7 +1283,7 @@ cfg_if! {
12831283
.field("d_off", &self.d_off)
12841284
.field("d_reclen", &self.d_reclen)
12851285
.field("d_type", &self.d_type)
1286-
// FIXME: .field("d_name", &self.d_name)
1286+
// FIXME(debug): .field("d_name", &self.d_name)
12871287
.finish()
12881288
}
12891289
}
@@ -1315,7 +1315,7 @@ cfg_if! {
13151315
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
13161316
f.debug_struct("sockaddr_un")
13171317
.field("sun_family", &self.sun_family)
1318-
// FIXME: .field("sun_path", &self.sun_path)
1318+
// FIXME(debug): .field("sun_path", &self.sun_path)
13191319
.finish()
13201320
}
13211321
}
@@ -1346,7 +1346,7 @@ cfg_if! {
13461346
f.debug_struct("sockaddr_storage")
13471347
.field("ss_family", &self.ss_family)
13481348
.field("__ss_align", &self.__ss_align)
1349-
// FIXME: .field("__ss_padding", &self.__ss_padding)
1349+
// FIXME(debug): .field("__ss_padding", &self.__ss_padding)
13501350
.finish()
13511351
}
13521352
}
@@ -1398,12 +1398,12 @@ cfg_if! {
13981398
impl fmt::Debug for utsname {
13991399
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
14001400
f.debug_struct("utsname")
1401-
// FIXME: .field("sysname", &self.sysname)
1402-
// FIXME: .field("nodename", &self.nodename)
1403-
// FIXME: .field("release", &self.release)
1404-
// FIXME: .field("version", &self.version)
1405-
// FIXME: .field("machine", &self.machine)
1406-
// FIXME: .field("domainname", &self.domainname)
1401+
// FIXME(debug): .field("sysname", &self.sysname)
1402+
// FIXME(debug): .field("nodename", &self.nodename)
1403+
// FIXME(debug): .field("release", &self.release)
1404+
// FIXME(debug): .field("version", &self.version)
1405+
// FIXME(debug): .field("machine", &self.machine)
1406+
// FIXME(debug): .field("domainname", &self.domainname)
14071407
.finish()
14081408
}
14091409
}

0 commit comments

Comments
 (0)