Skip to content
This repository was archived by the owner on Mar 14, 2023. It is now read-only.

Commit 7f29f7c

Browse files
committed
Don't ping the author of the PR
1 parent 60b211b commit 7f29f7c

File tree

2 files changed

+10
-8
lines changed

2 files changed

+10
-8
lines changed

highfive/newpr.py

+5-3
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,7 @@ def choose_reviewer(self, repo, owner, diff, exclude):
310310
# no eligible reviewer found
311311
return None
312312

313-
def get_to_mention(self, diff):
313+
def get_to_mention(self, diff, author):
314314
"""
315315
Get the list of people to mention.
316316
"""
@@ -346,7 +346,9 @@ def get_to_mention(self, diff):
346346

347347
mention_list = []
348348
for mention in to_mention:
349-
mention_list.append(mentions[mention])
349+
entry = mentions[mention]
350+
if entry["reviewers"] != author:
351+
mention_list.append(entry)
350352
return mention_list
351353

352354
def add_labels(self, owner, repo, issue):
@@ -377,7 +379,7 @@ def new_pr(self):
377379
reviewer = self.choose_reviewer(
378380
repo, owner, diff, author
379381
)
380-
to_mention = self.get_to_mention(diff)
382+
to_mention = self.get_to_mention(diff, author)
381383

382384
self.set_assignee(
383385
reviewer, owner, repo, issue, self.integration_user,

highfive/tests/test_newpr.py

+5-5
Original file line numberDiff line numberDiff line change
@@ -817,7 +817,7 @@ def test_msg_reviewer_repeat_contributor(self):
817817

818818
self.assert_set_assignee_branch_calls('foundReviewer', ['to'])
819819
self.mocks['choose_reviewer'].assert_not_called()
820-
self.mocks['get_to_mention'].assert_called_once_with('diff')
820+
self.mocks['get_to_mention'].assert_called_once_with('diff', 'prAuthor')
821821
self.mocks['welcome_msg'].assert_not_called()
822822
self.mocks['review_msg'].assert_not_called()
823823
self.mocks['post_comment'].assert_not_called()
@@ -1037,13 +1037,13 @@ def make_fakes(cls):
10371037
'global_': fakes.get_global_configs(),
10381038
}
10391039

1040-
def get_to_mention(self, diff, global_=None):
1041-
return self.get_to_mention_inner(diff, global_)
1040+
def get_to_mention(self, diff, author, global_=None):
1041+
return self.get_to_mention_inner(diff, author, global_)
10421042

10431043
@mock.patch('highfive.newpr.HighfiveHandler._load_json_file')
1044-
def get_to_mention_inner(self, diff, global_, mock_load_json):
1044+
def get_to_mention_inner(self, diff, author, global_, mock_load_json):
10451045
mock_load_json.return_value = deepcopy(global_ or {"groups": {}})
1046-
return self.handler.get_to_mention(diff)
1046+
return self.handler.get_to_mention(diff, author)
10471047

10481048
def choose_reviewer(
10491049
self, repo, owner, diff, exclude, global_=None

0 commit comments

Comments
 (0)