Skip to content

Commit 60738bd

Browse files
bors[bot]sunng87
andcommitted
Merge #45
45: Fix cargo build with minimal-versions r=Amanieu a=sunng87 For serde versions prior to 1.0.25, hashbrown built with serde feature will result in an error: ``` error[E0407]: method `deserialize_in_place` is not a member of trait `Deserialize` --> src/external_trait_impls/serde.rs:164:9 | 164 | / fn deserialize_in_place<D>(deserializer: D, place: &mut Self) -> Result<(), D::Error> 165 | | where 166 | | D: Deserializer<'de>, 167 | | { ... | 197 | | deserializer.deserialize_seq(SeqInPlaceVisitor(place)) 198 | | } | |_________^ not a member of trait `Deserialize` error: aborting due to previous error For more information about this error, try `rustc --explain E0407`. error: Could not compile `hashbrown`. ``` Change serde version to 1.0.25 explicitly will fix build with `cargo -Z minimal-versions build --features serde` Co-authored-by: Ning Sun <[email protected]>
2 parents fd429eb + 5b4a69f commit 60738bd

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ scopeguard = { version = "0.3", default-features = false }
1616

1717
# For external trait impls
1818
rayon = { version = "1.0", optional = true }
19-
serde = { version = "1.0", default-features = false, optional = true }
19+
serde = { version = "1.0.25", default-features = false, optional = true }
2020

2121
[dev-dependencies]
2222
lazy_static = "~1.2"

0 commit comments

Comments
 (0)