Skip to content

Rename or remove futures_unordered module in 0.2 #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aturon opened this issue Feb 23, 2018 · 2 comments
Closed

Rename or remove futures_unordered module in 0.2 #793

aturon opened this issue Feb 23, 2018 · 2 comments

Comments

@aturon
Copy link
Member

aturon commented Feb 23, 2018

The fact that we have a function and module both named futures_unordered is confusing both to people and to rustdoc.

@cramertj
Copy link
Member

cramertj commented Feb 26, 2018

I think it's fine to remove the function now that we have the FromIterator impl which does the same thing. I think the only reason the module exists is so that there's a place for IterMut, but this could probably be renamed to FuturesUnorderedIterMut or something and then reexported from the stream module.

@alexcrichton
Copy link
Member

I'd also be fine removing iteration as it didn't solve the original problem anyway

@aturon aturon added this to the 0.2 release milestone Mar 19, 2018
@aturon aturon closed this as completed in ffea47c Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants