Skip to content

futures-core 0.3.7 is breaking #2361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
leo60228 opened this issue Feb 25, 2021 · 1 comment
Closed

futures-core 0.3.7 is breaking #2361

leo60228 opened this issue Feb 25, 2021 · 1 comment

Comments

@leo60228
Copy link

The following chain of events can lead to futures-util failing to build despite none of the steps being individually abnormal:

  1. Add futures-util 0.3.6 as a dependency.
  2. Later, add a dependency depending on a newer version of futures-core.

Here's a repo demonstrating this (check the commit history): https://github.com/leo60228/futures-test

error[E0432]: unresolved import `futures_core::core_reexport`
  --> /home/leo60228/.cargo/registry/src/github.com-1ecc6299db9ec823/futures-util-0.3.6/src/lib.rs:55:9
   |
55 | pub use futures_core::core_reexport;
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ no `core_reexport` in the root

This is because futures-core 0.3.7 removed core_reexport. This seems like it should be fine, since it's only used internally by futures, but mismatched subcrate versions can cause this issue.

@taiki-e
Copy link
Member

taiki-e commented Feb 26, 2021

Fixed by #2233 (0.3.7) that removing the dependency on private API.

@taiki-e taiki-e closed this as completed Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants