Skip to content

Commit f484fff

Browse files
authored
Merge pull request #979 from cramertj/better-select
Use swap_remove in select_all to avoid O(n) copies
2 parents 42332a0 + a9d91c7 commit f484fff

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

futures-util/src/future/select_all.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ impl<A> Future for SelectAll<A>
5959
}).next();
6060
match item {
6161
Some((idx, res)) => {
62-
self.inner.remove(idx);
62+
self.inner.swap_remove(idx);
6363
let rest = mem::replace(&mut self.inner, Vec::new());
6464
match res {
6565
Ok(e) => Ok(Async::Ready((e, idx, rest))),

0 commit comments

Comments
 (0)