Remove needless borrows and method calls (#2259)

Author: taiki-e

futures-channel/src/mpsc/mod.rs

@@ -483,7 +483,7 @@ impl<T> UnboundedSenderInner<T> {
 
     /// Returns whether the sender send to this receiver.
     fn is_connected_to(&self, inner: &Arc<UnboundedInner<T>>) -> bool {
-        Arc::ptr_eq(&self.inner, &inner)
+        Arc::ptr_eq(&self.inner, inner)
     }
 
     /// Returns pointer to the Arc containing sender
@@ -664,7 +664,7 @@ impl<T> BoundedSenderInner<T> {
 
     /// Returns whether the sender send to this receiver.
     fn is_connected_to(&self, receiver: &Arc<BoundedInner<T>>) -> bool {
-        Arc::ptr_eq(&self.inner, &receiver)
+        Arc::ptr_eq(&self.inner, receiver)
     }
 
     /// Returns pointer to the Arc containing sender

futures-util/src/future/future/shared.rs

@@ -137,7 +137,7 @@ where
     /// is `COMPLETE`
     unsafe fn output(&self) -> &Fut::Output {
         match &*self.future_or_output.get() {
-            FutureOrOutput::Output(ref item) => &item,
+            FutureOrOutput::Output(ref item) => item,
             FutureOrOutput::Future(_) => unreachable!(),
         }
     }

futures-util/src/io/read_line.rs

@@ -38,7 +38,7 @@ pub(super) fn read_line_internal<R: AsyncBufRead + ?Sized>(
     read: &mut usize,
 ) -> Poll<io::Result<usize>> {
     let ret = ready!(read_until_internal(reader, cx, b'\n', bytes, read));
-    if str::from_utf8(&bytes).is_err() {
+    if str::from_utf8(bytes).is_err() {
         Poll::Ready(ret.and_then(|_| {
             Err(io::Error::new(io::ErrorKind::InvalidData, "stream did not contain valid UTF-8"))
         }))

futures-util/src/io/read_to_string.rs

@@ -38,7 +38,7 @@ fn read_to_string_internal<R: AsyncRead + ?Sized>(
     start_len: usize,
 ) -> Poll<io::Result<usize>> {
     let ret = ready!(read_to_end_internal(reader, cx, bytes, start_len));
-    if str::from_utf8(&bytes).is_err() {
+    if str::from_utf8(bytes).is_err() {
         Poll::Ready(ret.and_then(|_| {
             Err(io::Error::new(
                 io::ErrorKind::InvalidData,

futures-util/src/io/write_all_vectored.rs

@@ -186,7 +186,7 @@ mod tests {
             (vec![IoSlice::new(&[1, 1, 1]), IoSlice::new(&[2, 2, 2]), IoSlice::new(&[3, 3, 3])], &[1, 1, 1, 2, 2, 2, 3, 3, 3]),
         ];
 
-        for (mut input, wanted) in tests.into_iter() {
+        for (mut input, wanted) in tests {
             let mut dst = test_writer(2, 2);
             {
                 let mut future = dst.write_all_vectored(&mut *input);

futures-util/src/stream/futures_ordered.rs

@@ -214,7 +214,7 @@ impl<Fut: Future> Extend<Fut> for FuturesOrdered<Fut> {
     where
         I: IntoIterator<Item = Fut>,
     {
-        for item in iter.into_iter() {
+        for item in iter {
             self.push(item);
         }
     }

futures-util/src/stream/futures_unordered/mod.rs

@@ -626,7 +626,7 @@ impl<Fut> Extend<Fut> for FuturesUnordered<Fut> {
     where
         I: IntoIterator<Item = Fut>,
     {
-        for item in iter.into_iter() {
+        for item in iter {
             self.push(item);
         }
     }