address comments

Signed-off-by: tison <[email protected]>

Author: tisonkun

futures-util/src/future/future/mod.rs

@@ -10,6 +10,7 @@ use core::pin::Pin;
 
 use crate::fns::{inspect_fn, into_fn, ok_fn, InspectFn, IntoFn, OkFn};
 use crate::future::{assert_future, Either};
+use crate::pin_mut;
 use crate::stream::assert_stream;
 #[cfg(feature = "alloc")]
 use futures_core::future::{BoxFuture, LocalBoxFuture};
@@ -111,36 +112,6 @@ mod shared;
 #[cfg(any(feature = "std", all(feature = "alloc", feature = "spin")))]
 pub use self::shared::{Shared, WeakShared};
 
-/// Pins a value on the stack.
-///
-/// **Note:** Since Rust 1.68, this macro is soft-deprecated in favor of
-/// [`pin!`](https://doc.rust-lang.org/std/pin/macro.pin.html) macro
-/// in the standard library.
-///
-/// # Example
-///
-/// ```rust
-/// # use futures_util::pin_mut;
-/// # use core::pin::Pin;
-/// # struct Foo {}
-/// let foo = Foo { /* ... */ };
-/// pin_mut!(foo);
-/// let _: Pin<&mut Foo> = foo;
-/// ```
-#[macro_export]
-macro_rules! pin_mut {
-    ($($x:ident),* $(,)?) => { $(
-        // Move the value to ensure that it is owned
-        let mut $x = $x;
-        // Shadow the original binding so that it can't be directly accessed
-        // ever again.
-        #[allow(unused_mut)]
-        let mut $x = unsafe {
-            ::core::pin::Pin::new_unchecked(&mut $x)
-        };
-    )* }
-}
-
 impl<T: ?Sized> FutureExt for T where T: Future {}
 
 /// An extension trait for `Future`s that provides a variety of convenient

futures-util/src/lib.rs

@@ -328,3 +328,4 @@ mod abortable;
 
 mod fns;
 mod unfold_state;
+mod macros;

futures-util/src/macros.rs

@@ -0,0 +1,31 @@
+/// Pins a value on the stack.
+///
+/// Can safely pin values that are not `Unpin` by taking ownership.
+///
+/// **Note:** Since Rust 1.68, this macro is soft-deprecated in favor of
+/// [`pin!`](https://doc.rust-lang.org/std/pin/macro.pin.html) macro
+/// in the standard library.
+///
+/// # Example
+///
+/// ```rust
+/// # use futures_util::pin_mut;
+/// # use core::pin::Pin;
+/// # struct Foo {}
+/// let foo = Foo { /* ... */ };
+/// pin_mut!(foo);
+/// let _: Pin<&mut Foo> = foo;
+/// ```
+#[macro_export]
+macro_rules! pin_mut {
+    ($($x:ident),* $(,)?) => { $(
+        // Move the value to ensure that it is owned
+        let mut $x = $x;
+        // Shadow the original binding so that it can't be directly accessed
+        // ever again.
+        #[allow(unused_mut)]
+        let mut $x = unsafe {
+            ::core::pin::Pin::new_unchecked(&mut $x)
+        };
+    )* }
+}