Skip to content

start sending ETag headers #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
QuietMisdreavus opened this issue Mar 21, 2019 · 2 comments
Closed

start sending ETag headers #320

QuietMisdreavus opened this issue Mar 21, 2019 · 2 comments

Comments

@QuietMisdreavus
Copy link
Member

With the caching issues described in #316, it may be worth updating the headers we send with static files. Our current headers include a max-age of 12 months, which is useful most of the time, but has started to run into some issues in certain situations. Calculating an ETag for some file requests and shortening this cache duration could be helpful in getting CloudFront to properly update its CDN caches when necessary. Updating our request handling to also react to receiving these ETags could also save us from having to serve the files even if they aren't updated.

@najamelan
Copy link

This is a bit more work to implement than ETAGs (because of the hash based uri), but I think it is the correct way, and in the very least I think everyone should read this, so I share it here:

https://engineering.fb.com/web/this-browser-tweak-saved-60-of-requests-to-facebook/

@syphar
Copy link
Member

syphar commented Oct 13, 2022

I think we can close this issue since it's problems are partially solved, and partially moved:

@syphar syphar closed this as not planned Won't fix, can't repro, duplicate, stale Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants