Skip to content

Menus are cramped, dependencies wrap badly #1725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lilyball opened this issue Apr 15, 2022 · 3 comments
Closed

Menus are cramped, dependencies wrap badly #1725

lilyball opened this issue Apr 15, 2022 · 3 comments

Comments

@lilyball
Copy link

Recently the dropdown menus have started to look cramped, as though there's some padding missing at the bottom of each section and of the menu itself.

Additionally, I'm seeing dependencies getting wrapped without providing space for the wrapping, thus causing the wrapped portion to overlap the next dependency. Dependencies are also being wrapped more aggressively on Safari than on Firefox (likely due to there being a custom permanent scrollbar in Safari but Firefox on macOS is still using the system-provided overlay scrollbar), but I can still get a wrapped dependency with e.g. the assert_matches dependency on https://docs.rs/futures/latest/futures/.

Here's a screenshot taken in Safari that demonstrates both issues:

Screenshot showing the menu for Futures. Multiple dependencies are wrapped and overlap the next dependency, and the menu looks cramped.

Also in that screenshot you can see a subtle misalignment on the "Docs.rs crate page" link, presumably due to having an icon that's larger than the ones on the surrounding lines.

@syphar
Copy link
Member

syphar commented Apr 16, 2022

@GuillaumeGomez @jsha is this something that would be solved with #1720 or #1719 ?

@syphar
Copy link
Member

syphar commented Apr 16, 2022

Ah I'm stupid, this is what is described in #1719.
So it will be fixed by this PR

@syphar
Copy link
Member

syphar commented Apr 16, 2022

fixed and deployed in #1719

@syphar syphar closed this as completed Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants