Skip to content

Commit 7b7dd55

Browse files
committed
Url-encode parameters properly
1 parent f7f4fb4 commit 7b7dd55

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

src/web/releases.rs

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -205,14 +205,17 @@ fn get_search_results(
205205
.unwrap()
206206
});
207207

208-
let url = format!(
209-
"https://crates.io/api/v1/crates?page={page}&per_page={limit}&q={query}",
210-
page = page,
211-
limit = limit,
212-
query = query
213-
);
208+
let page: &str = &page.to_string();
209+
let url = url::Url::parse_with_params(
210+
"https://crates.io/api/v1/crates",
211+
&[
212+
("page", page),
213+
("per_page", &limit.to_string()),
214+
("q", query),
215+
],
216+
)?;
214217
debug!("fetching search results from {}", url);
215-
let releases: CratesIoReleases = HTTP_CLIENT.get(&url).send()?.json()?;
218+
let releases: CratesIoReleases = HTTP_CLIENT.get(url).send()?.json()?;
216219
let query = conn.prepare(
217220
"SELECT github_repos.stars, releases.target_name, releases.rustdoc_status
218221
FROM crates INNER JOIN releases ON crates.id = releases.crate_id

0 commit comments

Comments
 (0)