Skip to content

Commit 3bebf1c

Browse files
Merge pull request #354 from secretfader/aria-label
Add aria hints where labels were missing or unclear
2 parents f01dedd + 54310e4 commit 3bebf1c

File tree

3 files changed

+6
-6
lines changed

3 files changed

+6
-6
lines changed

templates/navigation.hbs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,11 @@
11
<div class="nav-container">
22
<div class="container">
3-
<div class="pure-menu pure-menu-horizontal">
3+
<div class="pure-menu pure-menu-horizontal" role="navigation" aria-label="Main navigation">
44
<form action="/releases/search" method="GET" class="landing-search-form-nav">
55
{{#unless varsb.show_search_form}}
6-
<input class="search-input-nav" name="query" type="text" placeholder="Find crate"{{#if varss.search_query}} value="{{varss.search_query}}"{{/if}}>
6+
<input class="search-input-nav" name="query" type="text" aria-label="Find crate by search query" placeholder="Find crate"{{#if varss.search_query}} value="{{varss.search_query}}"{{/if}}>
77
{{/unless}}
8-
<a href="/" class="pure-menu-heading pure-menu-link"><i class="fa fa-cubes fa-fw"></i> Docs.rs</a>
8+
<a href="/" class="pure-menu-heading pure-menu-link" aria-label="Docs.rs"><i class="fa fa-cubes fa-fw"></i> Docs.rs</a>
99
<ul class="pure-menu-list">
1010
<li class="pure-menu-item"><a href="/releases" class="pure-menu-link">Releases</a></li>
1111
<li class="pure-menu-item pure-menu-has-children pure-menu-allow-hover">

templates/navigation_rustdoc.hbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<div class="pure-menu pure-menu-horizontal">
44
<form action="/releases/search" method="GET" class="landing-search-form-nav">
55
{{#unless varsb.show_search_form}}
6-
<input class="search-input-nav" name="query" tabindex="-1" type="text" placeholder="Find crate"{{#if varss.search_query}} value="{{varss.search_query}}"{{/if}}>
6+
<input class="search-input-nav" name="query" aria-label="Find crate by search query" tabindex="-1" type="text" placeholder="Find crate"{{#if varss.search_query}} value="{{varss.search_query}}"{{/if}}>
77
{{/unless}}
88
<a href="/" class="pure-menu-heading pure-menu-link"><i class="fa fa-cubes fa-fw"></i><span class="title"> Docs.rs</span></a>
99
{{#with content.crate_details}}
@@ -93,7 +93,7 @@
9393
<a href="/crate/{{name}}/{{version}}/source/" title="Browse source of {{name}}-{{version}}" class="pure-menu-link{{#if ../../varsb.package_source_tab}} pure-menu-active{{/if}}"><i class="fa fa-fw fa-folder-open-o"></i><span class="title"> Source</span></a>
9494
</li>
9595
<li class="pure-menu-item pure-menu-has-children pure-menu-allow-hover">
96-
<a href="#" class="pure-menu-link"><i class="fa fa-fw fa-gears"></i><span class="title"> Platform</span></a>
96+
<a href="#" class="pure-menu-link" aria-label="Platform"><i class="fa fa-fw fa-gears"></i><span class="title"> Platform</span></a>
9797
<ul class="pure-menu-children">
9898
{{#each doc_targets}}
9999
<li class="pure-menu-item"><a href="/{{../../content.crate_details.name}}/{{../../content.crate_details.version}}/{{this}}/{{../../content.crate_details.target_name}}/" class="pure-menu-link">{{this}}</a></li>

templates/releases.hbs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<h1 class="brand"><i class="fa fa-cubes fa-fw"></i> Docs.rs</h1>
1515

1616
<form action="/releases/search" method="GET" class="landing-search-form">
17-
<div><input class="search-input" id="search" name="query" type="text" placeholder="Click or press 'S' to search" autofocus></div>
17+
<div><input class="search-input" id="search" name="query" type="text" aria-label="Find crate by search query" placeholder="Click or press 'S' to search" autofocus></div>
1818
<div class="buttons">
1919
<button type="submit" class="pure-button pure-button-normal">Search</button>
2020
<button type="submit" class="pure-button pure-button-normal" id="i-am-feeling-lucky-button">I'm Feeling Lucky</button>

0 commit comments

Comments
 (0)