Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom HTTP mocking setup #3125

Closed
Turbo87 opened this issue Dec 26, 2020 · 1 comment
Closed

Replace custom HTTP mocking setup #3125

Turbo87 opened this issue Dec 26, 2020 · 1 comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear

Comments

@Turbo87
Copy link
Member

Turbo87 commented Dec 26, 2020

In the crates.io testsuite we are currently using a custom HTTP mocking setup, based on implementing an HTTP proxy server that intercepts reqwest requests.

This setup is somewhat hard to use though, and it might be possible to use something like https://docs.rs/mockito instead, which could make it easier to understand and write tests for our codebase.

#3121 already introduces the mockito dependency for HTTP mocking of the pagerduty API, but it might be worth investigating if we could use it the same way for the GitHub and S3 API requests.

@Turbo87 Turbo87 added A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear labels Feb 14, 2021
@Turbo87
Copy link
Member Author

Turbo87 commented Oct 9, 2023

This has been implemented to some degree. Our custom HTTP recorder is a thing of the past now :)

@Turbo87 Turbo87 closed this as completed Oct 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

No branches or pull requests

1 participant