Limit crate names to 64 characters. Fixes #696.

Author: carols10cents

src/krate.rs

@@ -67,6 +67,8 @@ pub const ALL_COLUMNS: AllColumns = (crates::id, crates::name,
     crates::readme, crates::license, crates::repository,
     crates::max_upload_size);
 
+pub const MAX_NAME_LENGTH: usize = 64;
+
 type CrateQuery<'a> = crates::BoxedQuery<'a, Pg, <AllColumns as Expression>::SqlType>;
 
 #[derive(RustcEncodable, RustcDecodable)]
@@ -370,7 +372,10 @@ impl Crate {
     }
 
     pub fn valid_name(name: &str) -> bool {
-        Crate::valid_ident(name)
+        let under_max_length = name.chars()
+            .take(MAX_NAME_LENGTH + 1)
+            .count() <= MAX_NAME_LENGTH;
+        Crate::valid_ident(name) && under_max_length
     }
 
     fn valid_ident(name: &str) -> bool {

src/tests/krate.rs

@@ -14,7 +14,7 @@ use cargo_registry::dependency::EncodableDependency;
 use cargo_registry::download::EncodableVersionDownload;
 use cargo_registry::git;
 use cargo_registry::keyword::{Keyword, EncodableKeyword};
-use cargo_registry::krate::{Crate, EncodableCrate};
+use cargo_registry::krate::{Crate, EncodableCrate, MAX_NAME_LENGTH};
 use cargo_registry::upload as u;
 use cargo_registry::user::EncodableUser;
 use cargo_registry::version::EncodableVersion;
@@ -404,6 +404,7 @@ fn new_bad_names() {
 
     bad_name("");
     bad_name("foo bar");
+    bad_name(&"a".repeat(MAX_NAME_LENGTH + 1));
 }
 
 #[test]