Skip to content

Commit 548e0b4

Browse files
committed
models/crate-owner-invite: Remove obsolete invited_by_username field
`invited_by_username` isn't actually sent anymore by the v2 (aka. `private`) API and it had been showing an empty column for 14 months now... 😅
1 parent 8952d18 commit 548e0b4

File tree

4 files changed

+0
-9
lines changed

4 files changed

+0
-9
lines changed

app/models/crate-owner-invite.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import Model, { attr, belongsTo } from '@ember-data/model';
22

33
export default class CrateOwnerInvite extends Model {
4-
@attr invited_by_username;
54
@attr crate_name;
65
@attr crate_id;
76
@attr('date') created_at;

mirage/serializers/crate-owner-invitation.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,5 @@ export default BaseSerializer.extend({
3131

3232
hash.invitee_id = Number(hash.invitee_id);
3333
hash.inviter_id = Number(hash.inviter_id);
34-
35-
let inviter = this.schema.users.find(hash.inviter_id);
36-
hash.invited_by_username = inviter.login;
3734
},
3835
});

tests/mirage/me/crate-owner-invitations/list-test.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,15 +52,13 @@ module('Mirage | GET /api/v1/me/crate_owner_invitations', function (hooks) {
5252
crate_id: Number(nanomsg.id),
5353
crate_name: 'nanomsg',
5454
created_at: '2016-12-24T12:34:56Z',
55-
invited_by_username: 'janed',
5655
invitee_id: Number(user.id),
5756
inviter_id: Number(inviter.id),
5857
},
5958
{
6059
crate_id: Number(ember.id),
6160
crate_name: 'ember-rs',
6261
created_at: '2020-12-31T12:34:56Z',
63-
invited_by_username: 'wycats',
6462
invitee_id: Number(user.id),
6563
inviter_id: Number(inviter2.id),
6664
},

tests/mirage/private/crate-owner-invitations/get-test.js

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -43,15 +43,13 @@ module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) {
4343
crate_id: Number(nanomsg.id),
4444
crate_name: 'nanomsg',
4545
created_at: '2016-12-24T12:34:56Z',
46-
invited_by_username: 'janed',
4746
invitee_id: Number(user.id),
4847
inviter_id: Number(inviter.id),
4948
},
5049
{
5150
crate_id: Number(ember.id),
5251
crate_name: 'ember-rs',
5352
created_at: '2020-12-31T12:34:56Z',
54-
invited_by_username: 'wycats',
5553
invitee_id: Number(user.id),
5654
inviter_id: Number(inviter2.id),
5755
},
@@ -159,7 +157,6 @@ module('Mirage | GET /api/private/crate_owner_invitations', function (hooks) {
159157
crate_id: Number(ember.id),
160158
crate_name: 'ember-rs',
161159
created_at: '2020-12-31T12:34:56Z',
162-
invited_by_username: 'wycats',
163160
invitee_id: Number(user.id),
164161
inviter_id: Number(inviter2.id),
165162
},

0 commit comments

Comments
 (0)