Skip to content

extend TypeName with str type #437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nikomatsakis opened this issue May 5, 2020 · 2 comments · Fixed by #441
Closed

extend TypeName with str type #437

nikomatsakis opened this issue May 5, 2020 · 2 comments · Fixed by #441
Assignees
Labels
current-sprint Being worked on in the current sprint

Comments

@nikomatsakis
Copy link
Contributor

nikomatsakis commented May 5, 2020

As part of #368, we need to extend chalk's TypeName to model the built-in str type.

You can follow #394 which provides a rough model of what needs to be extended. str should be roughly like u32.

You would need to

  • add str to TypeName
  • extend parser to accept str as a type name, and add a suitable node to the AST
  • Update the current state table to include str. I don't think it requires any special handling, its impls live in the standard library (and it does not implement Sized).

This issue has been assigned to @Mcat12 via this comment.

@nikomatsakis nikomatsakis added the current-sprint Being worked on in the current sprint label May 5, 2020
@nikomatsakis
Copy link
Contributor Author

cc @Mcat12 -- maybe you are interested in claiming this issue?

@AzureMarker
Copy link
Member

@rustbot claim

@rustbot rustbot self-assigned this May 5, 2020
This was referenced May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current-sprint Being worked on in the current sprint
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants