refactor Parameter and ParameterKind

Author: basil-cow

book/src/types.md

@@ -57,8 +57,6 @@ not been thoroughly discussed by the Rust compiler team as a whole.
 Here is a (partial) list of some things that have to be adapted in
 Chalk as of today to match this document:
 
-* `Parameter<I>` needs to be renamed to `GenericArgument`
-* `Vec<Parameter<I>>` needs to be replaced with `GenericArguments`
 * Extract `TypeName` into something opaque to chalk-ir.
 * Dyn type equality should probably be driven by entailment.
 * Projections need to be renamed to aliases.

chalk-engine/src/context.rs

@@ -103,7 +103,7 @@ pub trait Context: Clone + Debug {
 
     /// A term that can be quantified over and unified -- in current
     /// Chalk, either a type or lifetime.
-    type Parameter: Debug;
+    type GenericArg: Debug;
 
     /// A rule like `DomainGoal :- Goal`.
     ///
@@ -354,13 +354,13 @@ pub trait UnificationOps<C: Context> {
     ///
     /// If the parameters fail to unify, then `Error` is returned
     // Used by: simplify
-    fn unify_parameters_into_ex_clause(
+    fn unify_generic_args_into_ex_clause(
         &mut self,
         interner: &C::Interner,
         environment: &C::Environment,
         variance: C::Variance,
-        a: &C::Parameter,
-        b: &C::Parameter,
+        a: &C::GenericArg,
+        b: &C::GenericArg,
         ex_clause: &mut ExClause<C>,
     ) -> Fallible<()>;
 }

chalk-engine/src/hh.rs

@@ -10,7 +10,7 @@ pub enum HhGoal<C: Context> {
     Implies(C::ProgramClauses, C::Goal),
     All(Vec<C::Goal>),
     Not(C::Goal),
-    Unify(C::Variance, C::Parameter, C::Parameter),
+    Unify(C::Variance, C::GenericArg, C::GenericArg),
     DomainGoal(C::DomainGoal),
 
     /// Indicates something that cannot be proven to be true or false

chalk-engine/src/simplify.rs

@@ -57,7 +57,7 @@ impl<C: Context> Forest<C> {
                             subgoal,
                         )));
                 }
-                HhGoal::Unify(variance, a, b) => infer.unify_parameters_into_ex_clause(
+                HhGoal::Unify(variance, a, b) => infer.unify_generic_args_into_ex_clause(
                     context.interner(),
                     &environment,
                     variance,

chalk-integration/src/db.rs

@@ -9,11 +9,11 @@ use chalk_ir::AssocTypeId;
 use chalk_ir::Canonical;
 use chalk_ir::ConstrainedSubst;
 use chalk_ir::Environment;
+use chalk_ir::GenericArg;
 use chalk_ir::Goal;
 use chalk_ir::ImplId;
 use chalk_ir::InEnvironment;
 use chalk_ir::OpaqueTyId;
-use chalk_ir::Parameter;
 use chalk_ir::ProgramClause;
 use chalk_ir::StructId;
 use chalk_ir::TraitId;
@@ -117,11 +117,11 @@ impl RustIrDatabase<ChalkIr> for ChalkDatabase {
     fn impls_for_trait(
         &self,
         trait_id: TraitId<ChalkIr>,
-        parameters: &[Parameter<ChalkIr>],
+        generic_args: &[GenericArg<ChalkIr>],
     ) -> Vec<ImplId<ChalkIr>> {
         self.program_ir()
             .unwrap()
-            .impls_for_trait(trait_id, parameters)
+            .impls_for_trait(trait_id, generic_args)
     }
 
     fn local_impls_to_coherence_check(&self, trait_id: TraitId<ChalkIr>) -> Vec<ImplId<ChalkIr>> {

chalk-integration/src/interner.rs

@@ -1,13 +1,14 @@
 use crate::tls;
 use chalk_ir::interner::{HasInterner, Interner};
 use chalk_ir::{
-    AliasTy, ApplicationTy, AssocTypeId, CanonicalVarKinds, Goals, Lifetime, OpaqueTy, OpaqueTyId,
-    ParameterKinds, ProgramClauseImplication, ProgramClauses, ProjectionTy, QuantifiedWhereClauses,
-    SeparatorTraitRef, Substitution, TraitId, Ty,
+    AliasTy, ApplicationTy, AssocTypeId, CanonicalVarKind, CanonicalVarKinds, Goals, Lifetime,
+    OpaqueTy, OpaqueTyId, ProgramClauseImplication, ProgramClauses, ProjectionTy,
+    QuantifiedWhereClauses, SeparatorTraitRef, Substitution, TraitId, Ty, VariableKind,
+    VariableKinds,
 };
 use chalk_ir::{
-    Goal, GoalData, LifetimeData, Parameter, ParameterData, ParameterKind, ProgramClause,
-    ProgramClauseData, QuantifiedWhereClause, StructId, TyData, UniverseIndex,
+    GenericArg, GenericArgData, Goal, GoalData, LifetimeData, ProgramClause, ProgramClauseData,
+    QuantifiedWhereClause, StructId, TyData,
 };
 use std::fmt;
 use std::fmt::Debug;
@@ -35,15 +36,15 @@ pub struct ChalkIr;
 impl Interner for ChalkIr {
     type InternedType = Arc<TyData<ChalkIr>>;
     type InternedLifetime = LifetimeData<ChalkIr>;
-    type InternedParameter = ParameterData<ChalkIr>;
+    type InternedGenericArg = GenericArgData<ChalkIr>;
     type InternedGoal = Arc<GoalData<ChalkIr>>;
     type InternedGoals = Vec<Goal<ChalkIr>>;
-    type InternedSubstitution = Vec<Parameter<ChalkIr>>;
+    type InternedSubstitution = Vec<GenericArg<ChalkIr>>;
     type InternedProgramClause = ProgramClauseData<ChalkIr>;
     type InternedProgramClauses = Vec<ProgramClause<ChalkIr>>;
     type InternedQuantifiedWhereClauses = Vec<QuantifiedWhereClause<ChalkIr>>;
-    type InternedParameterKinds = Vec<ParameterKind<()>>;
-    type InternedCanonicalVarKinds = Vec<ParameterKind<UniverseIndex>>;
+    type InternedVariableKinds = Vec<VariableKind<ChalkIr>>;
+    type InternedCanonicalVarKinds = Vec<CanonicalVarKind<ChalkIr>>;
     type DefId = RawId;
     type Identifier = Identifier;
 
@@ -105,26 +106,26 @@ impl Interner for ChalkIr {
             .or_else(|| Some(write!(fmt, "{:?}", lifetime.interned())))
     }
 
-    fn debug_parameter(
-        parameter: &Parameter<ChalkIr>,
+    fn debug_generic_arg(
+        generic_arg: &GenericArg<ChalkIr>,
         fmt: &mut fmt::Formatter<'_>,
     ) -> Option<fmt::Result> {
-        tls::with_current_program(|prog| Some(prog?.debug_parameter(parameter, fmt)))
+        tls::with_current_program(|prog| Some(prog?.debug_generic_arg(generic_arg, fmt)))
     }
 
-    fn debug_parameter_kinds(
-        parameter_kinds: &ParameterKinds<Self>,
+    fn debug_variable_kinds(
+        variable_kinds: &VariableKinds<Self>,
         fmt: &mut fmt::Formatter<'_>,
     ) -> Option<fmt::Result> {
-        tls::with_current_program(|prog| Some(prog?.debug_parameter_kinds(parameter_kinds, fmt)))
+        tls::with_current_program(|prog| Some(prog?.debug_variable_kinds(variable_kinds, fmt)))
     }
 
-    fn debug_parameter_kinds_with_angles(
-        parameter_kinds: &ParameterKinds<Self>,
+    fn debug_variable_kinds_with_angles(
+        variable_kinds: &VariableKinds<Self>,
         fmt: &mut fmt::Formatter<'_>,
     ) -> Option<fmt::Result> {
         tls::with_current_program(|prog| {
-            Some(prog?.debug_parameter_kinds_with_angles(parameter_kinds, fmt))
+            Some(prog?.debug_variable_kinds_with_angles(variable_kinds, fmt))
         })
     }
 
@@ -212,15 +213,15 @@ impl Interner for ChalkIr {
         lifetime
     }
 
-    fn intern_parameter(&self, parameter: ParameterData<ChalkIr>) -> ParameterData<ChalkIr> {
-        parameter
+    fn intern_generic_arg(&self, generic_arg: GenericArgData<ChalkIr>) -> GenericArgData<ChalkIr> {
+        generic_arg
     }
 
-    fn parameter_data<'a>(
+    fn generic_arg_data<'a>(
         &self,
-        parameter: &'a ParameterData<ChalkIr>,
-    ) -> &'a ParameterData<ChalkIr> {
-        parameter
+        generic_arg: &'a GenericArgData<ChalkIr>,
+    ) -> &'a GenericArgData<ChalkIr> {
+        generic_arg
     }
 
     fn intern_goal(&self, goal: GoalData<ChalkIr>) -> Arc<GoalData<ChalkIr>> {
@@ -244,15 +245,15 @@ impl Interner for ChalkIr {
 
     fn intern_substitution<E>(
         &self,
-        data: impl IntoIterator<Item = Result<Parameter<ChalkIr>, E>>,
-    ) -> Result<Vec<Parameter<ChalkIr>>, E> {
+        data: impl IntoIterator<Item = Result<GenericArg<ChalkIr>, E>>,
+    ) -> Result<Vec<GenericArg<ChalkIr>>, E> {
         data.into_iter().collect()
     }
 
     fn substitution_data<'a>(
         &self,
-        substitution: &'a Vec<Parameter<ChalkIr>>,
-    ) -> &'a [Parameter<ChalkIr>] {
+        substitution: &'a Vec<GenericArg<ChalkIr>>,
+    ) -> &'a [GenericArg<ChalkIr>] {
         substitution
     }
 
@@ -294,31 +295,31 @@ impl Interner for ChalkIr {
     ) -> &'a [QuantifiedWhereClause<Self>] {
         clauses
     }
-    fn intern_parameter_kinds<E>(
+    fn intern_generic_arg_kinds<E>(
         &self,
-        data: impl IntoIterator<Item = Result<ParameterKind<()>, E>>,
-    ) -> Result<Self::InternedParameterKinds, E> {
+        data: impl IntoIterator<Item = Result<VariableKind<ChalkIr>, E>>,
+    ) -> Result<Self::InternedVariableKinds, E> {
         data.into_iter().collect()
     }
 
-    fn parameter_kinds_data<'a>(
+    fn variable_kinds_data<'a>(
         &self,
-        parameter_kinds: &'a Self::InternedParameterKinds,
-    ) -> &'a [ParameterKind<()>] {
-        parameter_kinds
+        variable_kinds: &'a Self::InternedVariableKinds,
+    ) -> &'a [VariableKind<ChalkIr>] {
+        variable_kinds
     }
 
     fn intern_canonical_var_kinds<E>(
         &self,
-        data: impl IntoIterator<Item = Result<ParameterKind<UniverseIndex>, E>>,
+        data: impl IntoIterator<Item = Result<CanonicalVarKind<ChalkIr>, E>>,
     ) -> Result<Self::InternedCanonicalVarKinds, E> {
         data.into_iter().collect()
     }
 
     fn canonical_var_kinds_data<'a>(
         &self,
         canonical_var_kinds: &'a Self::InternedCanonicalVarKinds,
-    ) -> &'a [ParameterKind<UniverseIndex>] {
+    ) -> &'a [CanonicalVarKind<ChalkIr>] {
         canonical_var_kinds
     }
 }