-
Notifications
You must be signed in to change notification settings - Fork 530
Open
Description
Found this here: https://chromium-review.googlesource.com/c/chromium/src/+/4087043/4//COMMIT_MSG#26
The AR
env var can override the tool:
Lines 2651 to 2653 in 0e51f6d
if let Ok(p) = self.get_var("AR") { | |
return Ok((self.cmd(&p), p)); | |
} |
However the flags passed to it include "-nologo" and -out:
which then fails with invalid flag.
Lines 2107 to 2111 in 0e51f6d
if target.contains("msvc") { | |
let (mut cmd, program) = self.get_ar()?; | |
let mut out = OsString::from("-out:"); | |
out.push(dst); | |
cmd.arg(out).arg("-nologo"); |
It seems like if AR is specified in the env var, it shouldn't assume it can change the arguments based on the target being msvc?
Metadata
Metadata
Assignees
Labels
No labels