-
Notifications
You must be signed in to change notification settings - Fork 507
Bitode fembed-bitcode-marker breaking iOS debug builds #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I was able to do a few more tests while investigating the issue. Specifically,
|
I think we should probably not put this second option automatically. The --enable-bitcode do not look like a problem. |
cc @comex and @michaeleiselsc, would y'all be able to help diagnose what's going on here? FWIW @kali the change here was spurred on by discussion in rust-lang/rust#35968, but I'm very unfamiliar with iOS myself :( |
i thought bitcode support would be disabled by default? if so, can't we just use the previous behavior unless the user has added that -Z flag for bitcode? |
@michaeleiselsc it was in Rust yeah but that was after I made this change. How would you expect to enable this for the |
Looks like the same LLVM bug I mentioned in rust-lang/rust#48896 (comment). As I said there,
I guess I should have filed an issue in this repository too… |
Uh oh!
There was an error while loading. Please reload this page.
Hi,
It looks like the -fembed-bitcode-marker breaks the debug builds (it is not set on release bug).
To be honest, I'm not 100% sure where the actual issue is, but something looses track of the actually compiled symbols somewhere.
Here is a test-case. A rust wrapper library with a -sys underneath (with a
void native_function() {}
), try to build test on the rusty wrapper.First run: native, macos for reference.
Second run: test targetting ios, missing symbols while linking.
Third run: same with --release, disabling the fembed-bitcode-marker as a side effect, it compiles.
Forcing cc back to 1.0.5 make the probelm disappear. Or Using a patched cc-rs that do not put the bintcode-marker.
The text was updated successfully, but these errors were encountered: