-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add --public support for cargo add #13037
Copy link
Copy link
Closed
Labels
C-feature-requestCategory: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Command-addS-acceptedStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewZ-public-dependencyNightly: public-dependencyNightly: public-dependency
Metadata
Metadata
Assignees
Labels
C-feature-requestCategory: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`Command-addS-acceptedStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewStatus: Issue or feature is accepted, and has a team member available to help mentor or reviewZ-public-dependencyNightly: public-dependencyNightly: public-dependency
Type
Fields
Give feedbackNo fields configured for issues without a type.
Problem
rust-lang/rfcs#3516 calls for controlling the new
publicfield incargo addProposed Solution
Add
--publicand--no-publicflags. This will mirror--optional/--no-optionalTest cases
See the test cases for
--optionalfor patterns in naming, etc.Notes
The RFC called for
--public <bool>. ... I don't remember why I did that. I think it might have been due to some aspects of a previous design of the RFC and I forgot to update it. We can note this in the tracking issue for us to approve this deviation.