Skip to content

Commit db3ebb6

Browse files
committed
Better expect messages
Signed-off-by: hi-rustin <[email protected]>
1 parent 62bfdf0 commit db3ebb6

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

src/cargo/ops/cargo_add/mod.rs

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -313,7 +313,10 @@ fn resolve_dependency(
313313
selected
314314
} else {
315315
let source = crate::sources::PathSource::new(&path, src.source_id()?, config);
316-
let package = source.read_packages()?.pop().expect("at least one package");
316+
let package = source
317+
.read_packages()?
318+
.pop()
319+
.expect("read_packages errors when no packages");
317320
Dependency::from(package.summary())
318321
};
319322
selected
@@ -603,7 +606,10 @@ fn infer_package_for_git_source(
603606
src: &dyn std::fmt::Display,
604607
) -> CargoResult<Package> {
605608
let package = match packages.len() {
606-
0 => unreachable!(),
609+
0 => unreachable!(
610+
"this function should only be called with packages from `GitSource::read_packages` \
611+
and that call should error for us when there are no packages"
612+
),
607613
1 => packages.pop().expect("match ensured element is present"),
608614
_ => {
609615
let mut names: Vec<_> = packages

0 commit comments

Comments
 (0)