Skip to content

Commit 94ca096

Browse files
committed
Auto merge of #10018 - Some-Dood:chore/use-hashmap-from, r=alexcrichton
Chore: prefer `HashMap::from` rather than collecting `Vec` of tuples Hello there! Since Cargo upgraded to the 2021 Edition recently (which implies a `rust-version` of `1.56` or greater), I figured now may be a good time to use the new [`HashMap::from` shortcut](https://doc.rust-lang.org/stable/std/collections/struct.HashMap.html#impl-From%3C%5B(K%2C%20V)%3B%20N%5D%3E) of rust-lang/rust#84111. There should be no change in behavior here, but it does make the code a little bit neater! 🎉
2 parents 4cc3f4f + 144d941 commit 94ca096

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

src/bin/cargo/cli.rs

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,10 +15,10 @@ lazy_static::lazy_static! {
1515
// Maps from commonly known external commands (not builtin to cargo) to their
1616
// description, for the help page. Reserved for external subcommands that are
1717
// core within the rust ecosystem (esp ones that might become internal in the future).
18-
static ref KNOWN_EXTERNAL_COMMAND_DESCRIPTIONS: HashMap<&'static str, &'static str> = vec![
18+
static ref KNOWN_EXTERNAL_COMMAND_DESCRIPTIONS: HashMap<&'static str, &'static str> = HashMap::from([
1919
("clippy", "Checks a package to catch common mistakes and improve your Rust code."),
2020
("fmt", "Formats all bin and lib files of the current crate using rustfmt."),
21-
].into_iter().collect();
21+
]);
2222
}
2323

2424
pub fn main(config: &mut Config) -> CliResult {

0 commit comments

Comments
 (0)