Skip to content

Commit 05228f7

Browse files
committed
chore(ci): Check against beta first
Most breaking changes should be against beta and it would be good to have the context of whether we deviated from beta before checking against stable.
1 parent f035814 commit 05228f7

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

crates/xtask-bump-check/src/xtask.rs

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -177,22 +177,6 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car
177177
println!("::endgroup::");
178178
}
179179

180-
// Even when we test against baseline-rev, we still need to make sure a
181-
// change doesn't violate SemVer rules against crates.io releases. The
182-
// possibility of this happening is nearly zero but no harm to check twice.
183-
if github {
184-
println!("::group::SemVer Checks against crates.io");
185-
}
186-
let mut cmd = ProcessBuilder::new("cargo");
187-
cmd.arg("semver-checks")
188-
.arg("check-release")
189-
.arg("--workspace");
190-
gctx.shell().status("Running", &cmd)?;
191-
cmd.exec()?;
192-
if github {
193-
println!("::endgroup::");
194-
}
195-
196180
if let Some(referenced_commit) = referenced_commit.as_ref() {
197181
if github {
198182
println!("::group::SemVer Checks against {}", referenced_commit.id());
@@ -213,6 +197,22 @@ fn bump_check(args: &clap::ArgMatches, gctx: &cargo::util::GlobalContext) -> Car
213197
}
214198
}
215199

200+
// Even when we test against baseline-rev, we still need to make sure a
201+
// change doesn't violate SemVer rules against crates.io releases. The
202+
// possibility of this happening is nearly zero but no harm to check twice.
203+
if github {
204+
println!("::group::SemVer Checks against crates.io");
205+
}
206+
let mut cmd = ProcessBuilder::new("cargo");
207+
cmd.arg("semver-checks")
208+
.arg("check-release")
209+
.arg("--workspace");
210+
gctx.shell().status("Running", &cmd)?;
211+
cmd.exec()?;
212+
if github {
213+
println!("::endgroup::");
214+
}
215+
216216
status("no version bump needed for member crates.")?;
217217

218218
Ok(())

0 commit comments

Comments
 (0)