Skip to content

Commit f8c907f

Browse files
committed
more fixes
1 parent 7e0d2fe commit f8c907f

File tree

1 file changed

+14
-19
lines changed

1 file changed

+14
-19
lines changed

_posts/2018-03-01-Rust-1.24.1.md

Lines changed: 14 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@ appropriate page on our website, and check out the [detailed release notes for
2323

2424
## What's in 1.24.1 stable
2525

26-
As you know, we tend not to release point releases. In this case, Several minor
27-
regressions were found in 1.24.0 which collectively merited a release.
26+
Several minor regressions were found in 1.24.0 which collectively merited a
27+
release.
2828

29-
A quick summary of the changes: there are four.
29+
A quick summary of the changes:
3030

31-
* Do not abort when unwinding through FFI (this reverts behavior from 1.24.0)
31+
* Do not abort when unwinding through FFI (this reverts behavior added in 1.24.0)
3232
* Emit UTF-16 files for linker arguments on Windows
3333
* Make the error index generator work again
3434
* Cargo will warn on Windows 7 if an update is needed.
@@ -41,9 +41,11 @@ With that, let's dig into the details!
4141

4242
### Do not abort when unwinding through FFI
4343

44-
TL;DR: the behavior in 1.24.0 broke the `rlua` crate, and is being reverted. If
45-
you have since changed your code to take advantage of the behavior in 1.24.0,
46-
you'll need to revert it for now.
44+
TL;DR: the new behavior in 1.24.0 broke the `rlua` crate, and is being
45+
reverted. If you have since changed your code to take advantage of the behavior
46+
in 1.24.0, you'll need to revert it for now. While we still plan to introduce
47+
this behavior eventually, we will be rolling it out more slowly and with a new
48+
implementation strategy.
4749

4850
Quoting [the 1.24 annoucement](https://blog.rust-lang.org/2018/02/15/Rust-1.24.html):
4951

@@ -64,16 +66,9 @@ extern "C" fn panic_in_ffi() {
6466
>
6567
> In Rust 1.24, this code will now abort instead of producing undefined behavior.
6668
67-
As implemented, this functionality broke some users, notably, integration with
68-
the Lua language. We have reverted this behavior, and 1.24.1 will reintroduce
69-
the undefined behavior. Fundamentally, the aborting behavior we originally
70-
rolled out is a soundness fix, and we still plan on reintroducing it, but are
71-
going to be rolling it out a bit more slowly, and with a different
72-
implementation.
73-
74-
It started with [a bug filed against the `rlua`
75-
crate](https://github.com/chucklefish/rlua/issues/71). `rlua` is a package
76-
that provides high level bindings between Rust and the [Lua programming
69+
As mentioned above, this caused breakage. It started with [a bug filed against
70+
the `rlua` crate](https://github.com/chucklefish/rlua/issues/71). `rlua` is a
71+
package that provides high level bindings between Rust and the [Lua programming
7772
language](https://www.lua.org/).
7873

7974
> Side note: `rlua` is maintained by [Chucklefish](https://chucklefish.org/),
@@ -187,8 +182,8 @@ we may backport, otherwise, this functionality will be back in 1.26.
187182

188183
### Emit UTF-16 files for linker arguments on Windows
189184

190-
TL;DR: `rustc` stopped working for some Windows users. If it's been working for you,
191-
you were not affected by this bug.
185+
TL;DR: `rustc` stopped working for some Windows users in edge-case situations.
186+
If it's been working for you, you were not affected by this bug.
192187

193188
In constrast with the previous bug, which is very complex and tough to understand,
194189
this bug's impact is simple: if you have non-ASCII paths in the directory where

0 commit comments

Comments
 (0)