Skip to content

Commit b3a2a03

Browse files
Add -Cforce-frame-pointers to make the PDBALTPATH test case non-flaky on i686-pc-windows-msvc
1 parent 17148e5 commit b3a2a03

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

.github/workflows/main.yml

+5-4
Original file line numberDiff line numberDiff line change
@@ -112,13 +112,14 @@ jobs:
112112

113113
# Test that backtraces are still symbolicated if we don't embed an absolute
114114
# path to the PDB file in the binary.
115-
- run: |
116-
cargo clean
117-
cargo test
115+
# Add -Cforce-frame-pointers for stability. The test otherwise fails
116+
# non-deterministically on i686-pc-windows-msvc because the stack cannot be
117+
# unwound reliably. This failure is not related to the feature being tested.
118+
- run: cargo clean && cargo test
118119
if: contains(matrix.rust, 'msvc')
119120
name: "Test that backtraces are symbolicated without absolute PDB path"
120121
env:
121-
RUSTFLAGS: "-C link-arg=/PDBALTPATH:%_PDB%"
122+
RUSTFLAGS: "-Clink-arg=/PDBALTPATH:%_PDB% -Cforce-frame-pointers"
122123

123124
# Test that including as a submodule will still work, both with and without
124125
# the `backtrace` feature enabled.

0 commit comments

Comments
 (0)