Add global rls clippy_preference setting (#71)

* Add global rls clippy_preference setting
* Update readme mentioning support for clippy
* Update dependencies

Author: alexheretic

README.md

@@ -5,7 +5,7 @@ Rust language support for Atom-IDE, powered by the Rust Language Server (RLS).
 
 ## Features
  - Auto-completion
- - Diagnostics (errors and warnings from `rustc`, `clippy` support is pending on [rls#149](https://github.com/rust-lang-nursery/rls/issues/149))
+ - Diagnostics (errors and warnings from `rustc` and `clippy`, see `clippy_preference` setting)
  - Document outline
  - Go to definition (`ctrl` or `cmd` click)
  - Type information and Documentation on hover (hold `ctrl` or `cmd` for more information)
@@ -14,7 +14,7 @@ Rust language support for Atom-IDE, powered by the Rust Language Server (RLS).
  - Format on save (disabled by default, see `atom-ide-ui` settings)
  - Rls toolchain selection in package settings
  - Rls toolchain update checking at startup & every 6 hours thereafter
- - Global Rls configuration for `all_targets`
+ - Global Rls configuration for `all_targets`, `clippy_preference`
  - Per-project Rls configuration using `rls.toml` file at project root, see [rls#configuration](https://github.com/rust-lang-nursery/rls#configuration)
    ```toml
    # rls.toml

lib/index.js

@@ -265,6 +265,14 @@ class RustLanguageClient extends AutoLanguageClient {
             default: "Rls Default",
             order: 1,
             enum: ["On", "Off", "Rls Default"]
+          },
+          clippyPreference: {
+            title: "Clippy Preference",
+            description: 'Controls eagerness of clippy diagnostics. `Opt-in` requires each crate specifying `#![warn(clippy)]. Note clippy is only available on Rls releases that have it enabled at compile time.',
+            type: "string",
+            default: "Rls Default",
+            order: 2,
+            enum: ["On", "Opt-in", "Off", "Rls Default"]
           }
         }
       }

lib/rls-project.js

@@ -122,11 +122,14 @@ class RlsProject {
 
   // Default Rls config according to package settings & Rls defaults
   defaultConfig() {
-    const { allTargets } = atom.config.get("ide-rust.rlsDefaultConfig")
+    const { allTargets, clippyPreference } = atom.config.get("ide-rust.rlsDefaultConfig")
     const rlsConfig = {}
     if (allTargets === "On" || allTargets === "Off") {
       rlsConfig.all_targets = allTargets === "On"
     }
+    if (clippyPreference !== "Rls Default") {
+      rlsConfig.clippy_preference = clippyPreference
+    }
     return rlsConfig
   }
 }

package-lock.json

@@ -19,12 +19,12 @@
   },
   "dependencies": {
     "atom-languageclient": "^0.9.4",
-    "atom-package-deps": "^4.6.1",
+    "atom-package-deps": "^4.6.2",
     "toml": "^2.3.3",
     "underscore-plus": "^1.6.6"
   },
   "devDependencies": {
-    "eslint": "^4.18.2"
+    "eslint": "^4.19.1"
   },
   "scripts": {
     "test": "eslint lib test --max-warnings 0"