Skip to content

Commit d0dc6ba

Browse files
authored
Merge pull request #256 from Muscraft/right-align
fix: Right align suggestion line numbers
2 parents 2ef10ac + ea2932c commit d0dc6ba

File tree

2 files changed

+20
-17
lines changed

2 files changed

+20
-17
lines changed

src/renderer/mod.rs

Lines changed: 17 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -1718,7 +1718,7 @@ impl Renderer {
17181718
buffer.puts(
17191719
row_num - 1 + line - line_start.line,
17201720
0,
1721-
&self.maybe_anonymized(line),
1721+
&self.maybe_anonymized(line, max_line_num_len),
17221722
ElementStyle::LineNumber,
17231723
);
17241724
buffer.puts(
@@ -2066,7 +2066,7 @@ impl Renderer {
20662066
buffer.puts(
20672067
*row_num - 1,
20682068
0,
2069-
&self.maybe_anonymized(line_num + index),
2069+
&self.maybe_anonymized(line_num + index, max_line_num_len),
20702070
ElementStyle::LineNumber,
20712071
);
20722072
buffer.puts(
@@ -2097,7 +2097,7 @@ impl Renderer {
20972097
buffer.puts(
20982098
*row_num - 1,
20992099
0,
2100-
&self.maybe_anonymized(line_num + file_lines.len() - 1),
2100+
&self.maybe_anonymized(line_num + file_lines.len() - 1, max_line_num_len),
21012101
ElementStyle::LineNumber,
21022102
);
21032103
buffer.puts(
@@ -2131,7 +2131,7 @@ impl Renderer {
21312131
buffer.puts(
21322132
*row_num,
21332133
0,
2134-
&self.maybe_anonymized(line_num),
2134+
&self.maybe_anonymized(line_num, max_line_num_len),
21352135
ElementStyle::LineNumber,
21362136
);
21372137
buffer.puts(*row_num, max_line_num_len + 1, "+ ", ElementStyle::Addition);
@@ -2146,7 +2146,7 @@ impl Renderer {
21462146
buffer.puts(
21472147
*row_num,
21482148
0,
2149-
&self.maybe_anonymized(line_num),
2149+
&self.maybe_anonymized(line_num, max_line_num_len),
21502150
ElementStyle::LineNumber,
21512151
);
21522152
match &highlight_parts {
@@ -2182,7 +2182,7 @@ impl Renderer {
21822182
buffer.puts(
21832183
*row_num,
21842184
0,
2185-
&self.maybe_anonymized(line_num),
2185+
&self.maybe_anonymized(line_num, max_line_num_len),
21862186
ElementStyle::LineNumber,
21872187
);
21882188
buffer.puts(*row_num, max_line_num_len + 1, "+ ", ElementStyle::Addition);
@@ -2195,7 +2195,7 @@ impl Renderer {
21952195
buffer.puts(
21962196
*row_num,
21972197
0,
2198-
&self.maybe_anonymized(line_num),
2198+
&self.maybe_anonymized(line_num, max_line_num_len),
21992199
ElementStyle::LineNumber,
22002200
);
22012201
self.draw_col_separator(buffer, *row_num, max_line_num_len + 1);
@@ -2327,7 +2327,7 @@ impl Renderer {
23272327
buffer.puts(
23282328
line_offset,
23292329
0,
2330-
&format!("{:>max_line_num_len$}", self.maybe_anonymized(line_index)),
2330+
&self.maybe_anonymized(line_index, max_line_num_len),
23312331
ElementStyle::LineNumber,
23322332
);
23332333

@@ -2472,12 +2472,15 @@ impl Renderer {
24722472
buffer.putc(line, col, chr, style);
24732473
}
24742474

2475-
fn maybe_anonymized(&self, line_num: usize) -> Cow<'static, str> {
2476-
if self.anonymized_line_numbers {
2477-
Cow::Borrowed(ANONYMIZED_LINE_NUM)
2478-
} else {
2479-
Cow::Owned(line_num.to_string())
2480-
}
2475+
fn maybe_anonymized(&self, line_num: usize, max_line_num_len: usize) -> String {
2476+
format!(
2477+
"{:>max_line_num_len$}",
2478+
if self.anonymized_line_numbers {
2479+
Cow::Borrowed(ANONYMIZED_LINE_NUM)
2480+
} else {
2481+
Cow::Owned(line_num.to_string())
2482+
}
2483+
)
24812484
}
24822485

24832486
fn file_start(&self) -> &'static str {

tests/formatter.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1599,11 +1599,11 @@ error[E0277]: the size for values of type `T` cannot be known at compilation tim
15991599
|
16001600
help: consider removing the `?Sized` bound to make the type parameter `Sized`
16011601
|
1602-
8 - cargo
1603-
9 - fuzzy
1602+
8 - cargo
1603+
9 - fuzzy
16041604
10 - pizza
16051605
11 - jumps
1606-
8 + campy
1606+
8 + campy
16071607
|
16081608
"#]];
16091609
let renderer = Renderer::plain();

0 commit comments

Comments
 (0)