Skip to content
This repository was archived by the owner on Nov 21, 2018. It is now read-only.

Commit 9e6ebef

Browse files
committed
use API level 9 for arm and x86
This change makes them more compatible with Firefox releases, which currently use API level 9 as their baseline. Fixes #98.
1 parent 7efb3d5 commit 9e6ebef

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

master/master.cfg

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -861,7 +861,7 @@ class ConfigCommand(object):
861861

862862
# Set up the path to the android NDK
863863
if testing_android:
864-
s += " --arm-linux-androideabi-ndk=/android/ndk-arm-18"
864+
s += " --arm-linux-androideabi-ndk=/android/ndk-arm-9"
865865
s += " --i686-linux-android-ndk=/android/ndk-x86"
866866
s += " --aarch64-linux-android-ndk=/android/ndk-aarch64"
867867
s += " --disable-docs"

slaves/android/install-ndk.sh

100644100755
Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,18 @@ set -ex
88
curl -O http://dl.google.com/android/ndk/android-ndk-r10e-linux-x86_64.bin
99
chmod +x android-ndk-r10e-linux-x86_64.bin
1010
./android-ndk-r10e-linux-x86_64.bin > /dev/null
11+
# We use android-9 on arm and x86 for maximum compatibility with systems
12+
# like Firefox. We use 21 for aarch64 and x86-64 because that is the
13+
# earliest API level at which they are supported.
1114
bash android-ndk-r10e/build/tools/make-standalone-toolchain.sh \
12-
--platform=android-18 \
15+
--platform=android-9 \
1316
--toolchain=arm-linux-androideabi-4.8 \
14-
--install-dir=/android/ndk-arm-18 \
17+
--install-dir=/android/ndk-arm-9 \
1518
--ndk-dir=/android/android-ndk-r10e \
1619
--arch=arm
20+
# NB: this arm toolchain is used for testing the libc crate to ensure it
21+
# works against the most recent version of android. It cannot be combined
22+
# with the previous toolchain!
1723
bash android-ndk-r10e/build/tools/make-standalone-toolchain.sh \
1824
--platform=android-21 \
1925
--toolchain=arm-linux-androideabi-4.8 \
@@ -27,7 +33,7 @@ bash android-ndk-r10e/build/tools/make-standalone-toolchain.sh \
2733
--ndk-dir=/android/android-ndk-r10e \
2834
--arch=arm64
2935
bash android-ndk-r10e/build/tools/make-standalone-toolchain.sh \
30-
--platform=android-21 \
36+
--platform=android-9 \
3137
--toolchain=x86-4.9 \
3238
--install-dir=/android/ndk-x86 \
3339
--ndk-dir=/android/android-ndk-r10e \

0 commit comments

Comments
 (0)