Note why Handler::fatal is different from Sesssion::fatal

jyn514 · jyn514 · commit ebbc94957555 · 2021-05-08T23:13:04.000-04:00
diff --git a/compiler/rustc_errors/src/lib.rs b/compiler/rustc_errors/src/lib.rs
@@ -692,6 +692,7 @@ impl Handler {
         db
     }
 
+    // NOTE: intentionally doesn't raise an error so rustc_codegen_ssa only reports fatal errors in the main thread
     pub fn fatal(&self, msg: &str) -> FatalError {
         self.inner.borrow_mut().fatal(msg)
     }

Original file line number	Diff line number	Diff line change
`@@ -692,6 +692,7 @@ impl Handler {`
`692`	`692`	`db`
`693`	`693`	`}`
`694`	`694`
	`695`	`+ // NOTE: intentionally doesn't raise an error so rustc_codegen_ssa only reports fatal errors in the main thread`
`695`	`696`	`pub fn fatal(&self, msg: &str) -> FatalError {`
`696`	`697`	`self.inner.borrow_mut().fatal(msg)`
`697`	`698`	`}`