Skip to content

Commit b64e5b3

Browse files
committed
Auto merge of rust-lang#15333 - davidbarsky:davidbarsky/downgrade-vscode-to-1.75, r=lnicola
vscode: change minimum VS Code version to 1.75 from 1.78 I previously mentioned [in a comment](rust-lang/rust-analyzer#15265 (comment)) that folks at my employer are on 1.78, but I was incorrect: people are on 1.75. I know this is outside the standard version support policy, but I haven't seen any of the new features in VS Code be used in rust-analyzer. The most applicable feature in those three versions of VS Code that I can find [is lazily resolving code actions](https://code.visualstudio.com/updates/v1_78#_resolve-code-action-commands-in-resolvecodeaction), but it doesn't seem like rust-analyzer is making use of that feature. (I'll be posting a PR that adds support for `$saved_file` within the next day, so feel free to bump the minimum VS Code version back to 1.78 if/when that PR lands. This just makes vendoring the _actual_ change I'm interested in a little bit easier.)
2 parents febb3b3 + ba72216 commit b64e5b3

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

editors/code/package-lock.json

+5-5
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

editors/code/package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
}
2727
},
2828
"engines": {
29-
"vscode": "^1.78.0"
29+
"vscode": "^1.75.0"
3030
},
3131
"enabledApiProposals": [],
3232
"scripts": {
@@ -53,7 +53,7 @@
5353
"devDependencies": {
5454
"@tsconfig/strictest": "^2.0.1",
5555
"@types/node": "~16.11.7",
56-
"@types/vscode": "~1.78.1",
56+
"@types/vscode": "~1.75",
5757
"@typescript-eslint/eslint-plugin": "^6.0.0",
5858
"@typescript-eslint/parser": "^6.0.0",
5959
"@vscode/test-electron": "^2.3.3",

0 commit comments

Comments
 (0)