generalize 'forbidden feature' concept so that even (un)stable feature can be invalid to toggle

RalfJung · RalfJung · commit 8d3a263c795e · 2024-12-11T22:11:15.000+01:00
Also rename some things for extra clarity
diff --git a/src/lib.rs b/src/lib.rs
@@ -175,7 +175,11 @@ impl CodegenBackend for CraneliftCodegenBackend {
         }
     }
 
-    fn target_features(&self, sess: &Session, _allow_unstable: bool) -> Vec<rustc_span::Symbol> {
+    fn target_features_cfg(
+        &self,
+        sess: &Session,
+        _allow_unstable: bool,
+    ) -> Vec<rustc_span::Symbol> {
         // FIXME return the actually used target features. this is necessary for #[cfg(target_feature)]
         if sess.target.arch == "x86_64" && sess.target.os != "none" {
             // x86_64 mandates SSE2 support

Original file line number	Diff line number	Diff line change
`@@ -175,7 +175,11 @@ impl CodegenBackend for CraneliftCodegenBackend {`
`175`	`175`	`}`
`176`	`176`	`}`
`177`	`177`
`178`		`- fn target_features(&self, sess: &Session, _allow_unstable: bool) -> Vec<rustc_span::Symbol> {`
	`178`	`+ fn target_features_cfg(`
	`179`	`+ &self,`
	`180`	`+ sess: &Session,`
	`181`	`+ _allow_unstable: bool,`
	`182`	`+ ) -> Vec<rustc_span::Symbol> {`
`179`	`183`	`// FIXME return the actually used target features. this is necessary for #[cfg(target_feature)]`
`180`	`184`	`if sess.target.arch == "x86_64" && sess.target.os != "none" {`
`181`	`185`	`// x86_64 mandates SSE2 support`