Better lowercase/uppercase checks

Author: fasterthanlime

crates/ide-assists/src/handlers/generate_enum_variant.rs

@@ -41,7 +41,7 @@ pub(crate) fn generate_enum_variant(acc: &mut Assists, ctx: &AssistContext) -> O
     }
 
     let name_ref = path.segment()?.name_ref()?;
-    if name_ref.text().as_str().chars().next()?.is_ascii_lowercase() {
+    if name_ref.text().starts_with(char::is_lowercase) {
         // Don't suggest generating variant if the name starts with a lowercase letter
         return None;
     }

crates/ide-assists/src/handlers/generate_function.rs

@@ -73,7 +73,7 @@ fn gen_fn(acc: &mut Assists, ctx: &AssistContext) -> Option<()> {
             Some(hir::PathResolution::Def(hir::ModuleDef::Adt(adt))) => {
                 if let hir::Adt::Enum(_) = adt {
                     // Don't suggest generating function if the name starts with an uppercase letter
-                    if name_ref.text().chars().next()?.is_uppercase() {
+                    if name_ref.text().starts_with(char::is_uppercase) {
                         return None;
                     }
                 }