You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
2018-09-25 20:10:41 jamesmunns Updated the newsletter PR to mention it: https://github.com/rust-embedded/blog/pull/16
26
+
2018-09-25 20:10:54 jamesmunns (also reviews on that welcome)
27
+
2018-09-25 20:11:09 ~japaric jamesmunns: thanks
28
+
2018-09-25 20:11:15 ~japaric ok, moving on
29
+
2018-09-25 20:11:34 ~japaric since we are mainly working on docs atm I thought it may be a good idea to temporarily grow the resources team
30
+
2018-09-25 20:11:56 ~japaric so we have more reviewers and people monitoring the book repos
31
+
2018-09-25 20:12:19 ~japaric thoughts?
32
+
2018-09-25 20:12:39 jamesmunns A+++ from me. Life has gotten way busier than expected, and I appreciate all the book contributions from everyone
33
+
2018-09-25 20:12:45 ~japaric this would be up to the edition release / end of the year then new members can decide whether to stay in the team or leave
34
+
2018-09-25 20:12:58 @korken89 Sounds good!
35
+
2018-09-25 20:13:30 ~japaric also I know some WG members have volunteered for proofreading / reviewing PRs; having them on the resources team is an easier way to give them reviewer / push access
2018-09-25 20:18:12 ~japaric so I think we could the triaging ourselves
55
+
2018-09-25 20:18:18 ~japaric could do**
56
+
2018-09-25 20:18:58 ~japaric hopefully labeling things should make easier to find PRs that need review
57
+
2018-09-25 20:19:00 ~japaric e.g. https://github.com/search?q=org%3Arust-embedded++is%3Aopen+is%3Apr+label%3AT-resources&type=Issues
58
+
2018-09-25 20:19:20 @korken89 ryankurte: Thanks, I will have a look!
59
+
2018-09-25 20:20:03 @ryankurte seems reasonable?
60
+
2018-09-25 20:20:13 ~japaric idk if there's a better view of PRs from across a repo that have the same label
61
+
2018-09-25 20:20:52 @theJPster my main problem is going to review things that are already merged. Octobox doesn't seem to help with that.
62
+
2018-09-25 20:20:57 ~japaric in any case, if you have the time go around the PRs adding / updating the labels
63
+
2018-09-25 20:21:22 ~japaric there are labels for teams e.g. T-resources and labels for PR status e.g. S-wating-on-review
64
+
2018-09-25 20:21:36 ~japaric if they don't exist in a repo feel free to create then
65
+
2018-09-25 20:21:45 @therealprof +1
66
+
2018-09-25 20:21:58 @korken89 +1
67
+
2018-09-25 20:22:29 ~japaric we can try this for a few weeks and see if it helps reviewers find open PRs
68
+
2018-09-25 20:22:36 @korken89 Is there any place where normal labels are described? I saw them being used here and there, but not 100% sure on how to use them correctly
69
+
2018-09-25 20:23:11 ~japaric there's a doc for the labels the rust-lang/rust triage team uses
2018-09-25 20:25:35 ~japaric maybe link to the forge link from wg/ops/review.md
83
+
2018-09-25 20:25:39 @korken89 jamesmunns: +1 on having it visible in CONTRIBUTING.md
84
+
2018-09-25 20:26:10 jamesmunns I think it could make sense to have a "For Maintainers", and "For Contributors" section, somewhere
85
+
2018-09-25 20:26:29 jamesmunns Would also help with "onboarding" new WG members. A lot of our process is momentum
86
+
2018-09-25 20:27:04 ~japaric jamesmunns: that's what the ops directory is supposed to be for https://github.com/rust-embedded/wg/tree/master/ops
87
+
2018-09-25 20:27:13 ~japaric perhaps it's not visible enough?
88
+
2018-09-25 20:27:49 @theJPster I didn't know that was a thing
89
+
2018-09-25 20:27:51 jamesmunns Ah, I thought that was more for traditional devops (hosting, infra, etc) topics. but to be fair I haven't kept tabs on that as well as I should have
90
+
2018-09-25 20:28:12 jamesmunns (aside: is "traditional devops" actually a thing?)
91
+
2018-09-25 20:28:19 ~japaric crafting a common CONTRIBUTING.md sounds good but I think we are going off-topic here
92
+
2018-09-25 20:28:49 ~japaric we are near the half hour mark so let's move to reviewing edition issues
93
+
2018-09-25 20:29:24 ~japaric issue 1, book intro
94
+
2018-09-25 20:29:30 ~japaric I think this is in good shape now
95
+
2018-09-25 20:29:40 ~japaric jamesmunns: there's a TODO in the landing page
2018-09-25 20:42:14 jamesmunns I have only basic notes, my next book focus is the Type State Programming Chapter
136
+
2018-09-25 20:42:41 jamesmunns I will open up a new PR with the notes from my RustConf talk, in case the diagram or slight outline inspires someone else
2018-09-25 20:43:47 ~japaric issue 6, static guarantees chapter would be PR 15, right?
139
+
2018-09-25 20:43:49 thenewwazoo I've been relying _very_ heavily on some exploratory work I've been doing for ADC trait design, so I may be
140
+
2018-09-25 20:43:51 ~japaric jamesmunns: ^
141
+
2018-09-25 20:44:06 thenewwazoo that is, regarding the type system to enforce safe behavior
142
+
2018-09-25 20:44:21 jamesmunns PR#15 is the old "singletons" chapter
143
+
2018-09-25 20:44:27 thenewwazoo so please do post your notes, jamesmunns
144
+
2018-09-25 20:44:53 jamesmunns static guarantees became "type state programming", but there is probably more to cover around static guarantees than that
145
+
2018-09-25 20:45:22 jamesmunns https://github.com/rust-embedded/book/pull/15/commits/7791f066de96e9449a9dcfe0117c30cc41094dd9 is the last commit before I reduced PR#15 to only cover peripherals
146
+
2018-09-25 20:45:40 jamesmunns I will re-add those sections to two new PRs: One for Type State, one for Portability
147
+
2018-09-25 20:45:50 jamesmunns I don't have any other notes around static guarantees, however.
148
+
2018-09-25 20:46:51 ~japaric ok, we might want to review the outline after PR#15 lands but let's do that on the issue tracker
149
+
2018-09-25 20:47:10 ~japaric tagged PR#15 as waiting-on-review
150
+
2018-09-25 20:47:28 jamesmunns https://github.com/rust-embedded/book/tree/7791f066de96e9449a9dcfe0117c30cc41094dd9/src/typestate-programming is probably easier to see what I am going to open a PR for
2018-09-25 20:49:49 * japaric has not been following
161
+
2018-09-25 20:49:52 jamesmunns author wrote "I fixed the marked sections in the existing text, but I'll try to finish the rest of it by the end of the week!"
162
+
2018-09-25 20:49:55 jamesmunns (yesterday)
163
+
2018-09-25 20:50:03 cr1901 If there's 5 mins at the end, may I suggest another book section if it's not been discussed already?
164
+
2018-09-25 20:50:10 jamesmunns I can ping spacekookie at work tomorrow
165
+
2018-09-25 20:50:30 ~japaric jamesmunns: thanks
166
+
2018-09-25 20:50:35 ~japaric tagged as waiting-on-author
167
+
2018-09-25 20:51:13 ~japaric issue 9, outline is blocked on having more content; moving on
168
+
2018-09-25 20:51:25 ~japaric issue 10, the debugging book
169
+
2018-09-25 20:51:41 ~japaric ryankurte opened issues for the chapters
170
+
2018-09-25 20:52:10 ~japaric korken89: maybe you can coordinate with ryankurte to see how you can tackle the issues?
171
+
2018-09-25 20:52:34 ~japaric (or were you going to review instead of write?)
172
+
2018-09-25 20:52:51 @korken89 I think we can do that, the plan was to help writing
173
+
2018-09-25 20:52:53 ~japaric cr1901: may be best to open an issue in the book repo
174
+
2018-09-25 20:53:03 ~japaric korken89: +1
175
+
2018-09-25 20:53:12 cr1901 japaric: Ack will do
176
+
2018-09-25 20:53:22 cr1901 Atm I have nothing more to add, just listening :P
0 commit comments