Skip to content

cortex-m-semihosting: Ship a 1.0 release #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
thejpster opened this issue Jan 9, 2020 · 3 comments
Open
1 task done

cortex-m-semihosting: Ship a 1.0 release #290

thejpster opened this issue Jan 9, 2020 · 3 comments

Comments

@thejpster
Copy link
Contributor

thejpster commented Jan 9, 2020

Part of rust-embedded/wg#383

Blockers:

@jonas-schievink
Copy link
Contributor

rust-embedded/cortex-m-semihosting#41 and rust-embedded/cortex-m-semihosting#48 are both breaking changes. Would be good to get them in before 1.0.

@japaric
Copy link
Member

japaric commented Jan 14, 2020

I would say rust-embedded/cortex-m-semihosting#49 is a blocker: can we even get hprintln! to work on multi-core hardware? if not, how should we indicate that's unsound in multi-core context? make it unsafe to call? remove it? Cargo feature it?

make it unsafe to call?

if we go this route then device-specific crates (PAC, HAL and the like) can expose a safe wrapper to it if they know the crate will only ever be used on a single-core device

@jonas-schievink
Copy link
Contributor

Yeah, added rust-embedded/cortex-m-semihosting#49.

if we go this route then device-specific crates (PAC, HAL and the like) can expose a safe wrapper to it if they know the crate will only ever be used on a single-core device

That doesn't sound horrible. I was thinking of doing something like this for bare_metal::Mutex itself too.

@jonas-schievink jonas-schievink transferred this issue from rust-embedded/cortex-m-semihosting Nov 10, 2020
@jonas-schievink jonas-schievink changed the title Ship a 1.0 release cortex-m-semihosting: Ship a 1.0 release Nov 10, 2020
adamgreig pushed a commit that referenced this issue Jan 12, 2022
290: Beef up CI r=therealprof a=jonas-schievink

Closes rust-embedded/cortex-m-rt#233
Closes rust-embedded/cortex-m-rt#80

Co-authored-by: Jonas Schievink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants