Skip to content

Add XDG Support to confy #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 27, 2025
Merged

Add XDG Support to confy #119

merged 5 commits into from
Oct 27, 2025

Conversation

@deg4uss3r
Copy link
Contributor

@deg4uss3r deg4uss3r commented May 25, 2025 •
edited
Loading

This PR:

  • Removes the directories crate in favor of etcetera
  • Bumps the project to version 2.0.0
  • Moves config creation and reading to only use $XDG_CONFIG_HOME via etcetera AppStrategy rules
  • Some updated rustfmt from version 1.88

Resolves #117

@deg4uss3r deg4uss3r requested a review from matthiasbeyer May 25, 2025 18:50
@deg4uss3r deg4uss3r force-pushed the rth/introduce_xdg branch from 0d982cc to 45bfa32 Compare May 25, 2025 18:55
@deg4uss3r deg4uss3r mentioned this pull request May 25, 2025
Closed
@strega-nil
Copy link

I'll take a look at this tomorrow! Thanks for the PR.

strega-nil
strega-nil reviewed May 26, 2025
View reviewed changes
Copy link

@strega-nil strega-nil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, I'm really uncomfortable with the idea that one would have a silent, seriously breaking change behind a flag that could get accidentally turned on by a dependency. It would be nice if we checked for both locations on macOS, and maybe had a way to select which method should be used by the downstream application (since, for example, GUI apps may want to put their non-user-editable configuration into ~/Library)

@deg4uss3r deg4uss3r requested a review from Zykino July 23, 2025 01:02
Zykino
Zykino previously approved these changes Jul 23, 2025
View reviewed changes
Copy link
Contributor

@Zykino Zykino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t really know how to review the code here. I don’t know the directory, even less etcetera crate. 😅 (Also a lot is happening IRL for me so, don’t block on me please :) )

@deg4uss3r deg4uss3r force-pushed the rth/introduce_xdg branch 2 times, most recently from e4b0c44 to 56833ed Compare September 4, 2025 01:38
@deg4uss3r
Add a change strategy example
4170590
@deg4uss3r
Document functions and remove helper function that's only used once. …
724e3fe 
…Finally move the CI to use a single thread as the changing of the strategy is based on atomics and can fail if multiple threads are changing it at once
@deg4uss3r deg4uss3r merged commit 286668a into rust-cli:master Oct 27, 2025
22 checks passed
@deg4uss3r deg4uss3r deleted the rth/introduce_xdg branch October 27, 2025 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Zykino Zykino Zykino left review comments

@matthiasbeyer matthiasbeyer Awaiting requested review from matthiasbeyer

+2 more reviewers

@eirnym eirnym eirnym left review comments

@strega-nil strega-nil strega-nil left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support XDG directories on macOS

4 participants

@deg4uss3r @strega-nil @eirnym @Zykino