CI: Use new cargo rmbt tool (incl. bump MSRV to 1.74.0) #883
Conversation
|
Probably should have an ack from @nyonson before merge, I hacked this pretty quickly without thinking super hard. |
Just allow the lint to pass ignoring the large error return size.
tcharding
force-pushed
the
push-zktvwmtnuzlo
branch
from
d7b8c8b to
0719273
Compare
Add import to fix the benchmarks. Just allow the lint to pass ignoring the large error return size.
In line with `rust-bitcoin` bump the MSRV. Remove `clippy.toml` now it is not needed with this toolchain.
tcharding
force-pushed
the
push-zktvwmtnuzlo
branch
from
0719273 to
b6dad76
Compare
tcharding
changed the title
clippy emits: warning: unnecessary parentheses around closure body As suggested remove the parentheses.
Use `to_keypair` as suggested by the linter.
Use Nicks mad new tool to run CI. To do this I copied what is in `rust-psbt`, guessed at what `bench` should be, and used the latest commit hash from `rust-bitcoin-maintainer-tools` repo.
tcharding
force-pushed
the
push-zktvwmtnuzlo
branch
from
b6dad76 to
ed9195b
Compare
|
@nyonson, your CI work is shit-hot mate. Well done. Want to do it in |
|
In 1231487: The commit description has some cruft about error return sizes which isn't applicable to this commit. |
|
In f58468d: This bumps the MSRV to 1.74, which I'd rather not do as long as we depend on rust-bitcoin 0.32. But also, you say 1.64 somewhere (typo). |
|
The MSRV will also be an issue for rust-elements. We can attempt to back the MSRV for rbmt up, or we can figure out how we can |
|
@apoelstra as it is right now in ed9195b, it actually installs |
|
Awesome. So let's try doing this one without the MSRV bump. |
3 participants
Use Nicks mad new tool to run CI. To do this I copied what is in
rust-psbt, guessed at whatbenchshould be, and used the latest commit hash fromrust-bitcoin-maintainer-toolsrepo.Note: Includes a bump of the MSRV to 1.74.0 - do we want this separate?