Skip to content

usage of unsafe is unsound #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
BenjaminBrienen opened this issue Feb 23, 2025 · 1 comment
Closed

usage of unsafe is unsound #188

BenjaminBrienen opened this issue Feb 23, 2025 · 1 comment

Comments

@BenjaminBrienen
Copy link

See: #187

miri finds issues in the current implementation. This causes downstream crates, including rust-analyzer and wgsl-analyzer to also fail under miri.
@bjorn3
Copy link

bjorn3 commented Feb 24, 2025

Duplicate of #163. Also try using miri with tree borrows rather than stacked borrows. Stacked borrows doesn't support the &Header pattern that rowan needs, while tree borrows is just fine with it: rust-lang/unsafe-code-guidelines#256

@Veykril Veykril closed this as completed Feb 24, 2025
@BenjaminBrienen BenjaminBrienen mentioned this issue Feb 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Veykril @bjorn3 @BenjaminBrienen