From 86b476f41bb42e0ced1b255c347376ea730c2c5d Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Thu, 16 Jan 2025 22:47:24 -0800 Subject: [PATCH 1/7] bump versions and don't persist creds anywhere that we don't need to --- .github/workflows/acceptance.yml | 2 ++ .github/workflows/build.yml | 2 ++ .github/workflows/lint.yml | 2 ++ .github/workflows/release.yml | 2 +- .github/workflows/test.yml | 2 ++ 5 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.github/workflows/acceptance.yml b/.github/workflows/acceptance.yml index 87e6af8..25d2e46 100644 --- a/.github/workflows/acceptance.yml +++ b/.github/workflows/acceptance.yml @@ -17,6 +17,8 @@ jobs: steps: - name: checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: fetch crystal version id: crystal-version diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 9933a08..9368254 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -22,6 +22,8 @@ jobs: steps: - name: checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: fetch crystal version id: crystal-version diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index f0f6ec2..75b289e 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -20,6 +20,8 @@ jobs: steps: - name: checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: fetch crystal version id: crystal-version diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 01ed12c..fc33839 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -62,7 +62,7 @@ jobs: - name: Push a Release id: release - uses: ncipollo/release-action@v1.14.0 + uses: ncipollo/release-action@v1.15.0 with: artifacts: "./releases/*" tag: ${{ env.VERSION }} diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index 6d58ecb..deda1af 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -20,6 +20,8 @@ jobs: steps: - name: checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: fetch crystal version id: crystal-version From a134f0cd2fb14e04978df1f88e6e64852309cfc1 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Thu, 16 Jan 2025 22:47:35 -0800 Subject: [PATCH 2/7] exclude .git from docker builds explictly --- .dockerignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.dockerignore b/.dockerignore index 257efd6..a0a3705 100644 --- a/.dockerignore +++ b/.dockerignore @@ -1,3 +1,4 @@ +.git/ docs/ vendor/.cache/ vendor/shards/install/ From b48c86caaad0b3bf10bccd6a48ac9be3c677dc38 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Thu, 16 Jan 2025 22:51:17 -0800 Subject: [PATCH 3/7] fix --- .github/workflows/docker.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/docker.yml b/.github/workflows/docker.yml index 2cd6c7d..d99086b 100644 --- a/.github/workflows/docker.yml +++ b/.github/workflows/docker.yml @@ -46,6 +46,8 @@ jobs: steps: - name: checkout uses: actions/checkout@v4 + with: + persist-credentials: false - name: extract image metadata id: meta From f47a503620d737c238872dcf74a37476e2bf494a Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Thu, 16 Jan 2025 22:53:51 -0800 Subject: [PATCH 4/7] workflow pins to SHAs --- .github/workflows/acceptance.yml | 2 +- .github/workflows/build.yml | 2 +- .github/workflows/lint.yml | 2 +- .github/workflows/release.yml | 6 +++--- .github/workflows/test.yml | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/acceptance.yml b/.github/workflows/acceptance.yml index 25d2e46..a2b175e 100644 --- a/.github/workflows/acceptance.yml +++ b/.github/workflows/acceptance.yml @@ -25,7 +25,7 @@ jobs: run: echo "crystal=$(cat .crystal-version)" >> $GITHUB_OUTPUT - name: install crystal - uses: crystal-lang/install-crystal@v1.8.2 + uses: crystal-lang/install-crystal@cdf26dcd488490c9939e9d4d62cab169c9e4f20d # pin@v1.8.2 with: crystal: ${{ steps.crystal-version.outputs.crystal }} diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 9368254..92b0f37 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -30,7 +30,7 @@ jobs: run: echo "crystal=$(cat .crystal-version)" >> $GITHUB_OUTPUT - name: install crystal - uses: crystal-lang/install-crystal@v1.8.2 + uses: crystal-lang/install-crystal@cdf26dcd488490c9939e9d4d62cab169c9e4f20d # pin@v1.8.2 with: crystal: ${{ steps.crystal-version.outputs.crystal }} diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 75b289e..4a28783 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -28,7 +28,7 @@ jobs: run: echo "crystal=$(cat .crystal-version)" >> $GITHUB_OUTPUT - name: install crystal - uses: crystal-lang/install-crystal@v1.8.2 + uses: crystal-lang/install-crystal@cdf26dcd488490c9939e9d4d62cab169c9e4f20d # pin@v1.8.2 with: crystal: ${{ steps.crystal-version.outputs.crystal }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index fc33839..f16e317 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -23,7 +23,7 @@ jobs: run: echo "crystal=$(cat .crystal-version)" >> $GITHUB_OUTPUT - name: install crystal - uses: crystal-lang/install-crystal@v1.8.2 + uses: crystal-lang/install-crystal@cdf26dcd488490c9939e9d4d62cab169c9e4f20d # pin@v1.8.2 with: crystal: ${{ steps.crystal-version.outputs.crystal }} @@ -54,7 +54,7 @@ jobs: name: runway-binaries path: releases/ - - uses: actions/create-github-app-token@v1.11.1 + - uses: actions/create-github-app-token@c1a285145b9d317df6ced56c09f525b5c2b6f755 # pin@v1.11.1 id: app-token with: app-id: ${{ vars.APP_ID }} @@ -62,7 +62,7 @@ jobs: - name: Push a Release id: release - uses: ncipollo/release-action@v1.15.0 + uses: ncipollo/release-action@cdcc88a9acf3ca41c16c37bb7d21b9ad48560d87 # pin@v1.15.0 with: artifacts: "./releases/*" tag: ${{ env.VERSION }} diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index deda1af..15ababd 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -28,7 +28,7 @@ jobs: run: echo "crystal=$(cat .crystal-version)" >> $GITHUB_OUTPUT - name: install crystal - uses: crystal-lang/install-crystal@v1.8.2 + uses: crystal-lang/install-crystal@cdf26dcd488490c9939e9d4d62cab169c9e4f20d # pin@v1.8.2 with: crystal: ${{ steps.crystal-version.outputs.crystal }} From 39fe6e20795141dab3fb9ca0e306a11cb948966d Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Thu, 16 Jan 2025 22:54:58 -0800 Subject: [PATCH 5/7] bump version --- acceptance/logs/expected.log | 2 +- shard.yml | 2 +- src/version.cr | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/acceptance/logs/expected.log b/acceptance/logs/expected.log index 5fe4212..a80ffa2 100644 --- a/acceptance/logs/expected.log +++ b/acceptance/logs/expected.log @@ -3,7 +3,7 @@ INFO: 📖 loading runway configuration DEBUG: attempting to load config from acceptance/config/config.yml INFO: ✅ loaded configuration successfully INFO: 🚚 2 projects loaded -INFO: 🛫 starting runway - version: v0.2.3 +INFO: 🛫 starting runway - version: v0.2.4 INFO: 📦 starting project project-1 INFO: 🕐 scheduling event with interval 3s for project-1 INFO: 📦 starting project project-2 diff --git a/shard.yml b/shard.yml index 3a808e0..93ab4a7 100644 --- a/shard.yml +++ b/shard.yml @@ -1,5 +1,5 @@ name: runway -version: 0.2.3 +version: 0.2.4 authors: - GrantBirki diff --git a/src/version.cr b/src/version.cr index 11438b2..5b342ca 100644 --- a/src/version.cr +++ b/src/version.cr @@ -1,3 +1,3 @@ module Runway - VERSION = "v0.2.3" + VERSION = "v0.2.4" end From 260167feab582af26c03a395015038dd512329d7 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Thu, 16 Jan 2025 22:57:14 -0800 Subject: [PATCH 6/7] upgrade to crystal `v1.15.0` --- .crystal-version | 2 +- Dockerfile | 2 +- shard.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.crystal-version b/.crystal-version index 61ce01b..141f2e8 100644 --- a/.crystal-version +++ b/.crystal-version @@ -1 +1 @@ -1.13.2 +1.15.0 diff --git a/Dockerfile b/Dockerfile index ed237aa..2c8695e 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,5 @@ # https://github.com/84codes/crystal-container-images -FROM 84codes/crystal:1.13.2-ubuntu-24.04 AS builder +FROM 84codes/crystal:1.15.0-ubuntu-24.04 AS builder LABEL org.opencontainers.image.title="runway" LABEL org.opencontainers.image.description="clearing code for take off" diff --git a/shard.yml b/shard.yml index 93ab4a7..89ef63b 100644 --- a/shard.yml +++ b/shard.yml @@ -8,7 +8,7 @@ targets: runway: main: src/cli.cr -crystal: ">= 1.13.2" +crystal: ">= 1.15.0" license: MIT From aba5c2ff76a4f4fb2ddbad5b61988ccb3c56bea6 Mon Sep 17 00:00:00 2001 From: GrantBirki Date: Thu, 16 Jan 2025 23:06:21 -0800 Subject: [PATCH 7/7] go down to `1.14.1` crystal --- .crystal-version | 2 +- Dockerfile | 2 +- shard.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.crystal-version b/.crystal-version index 141f2e8..63e799c 100644 --- a/.crystal-version +++ b/.crystal-version @@ -1 +1 @@ -1.15.0 +1.14.1 diff --git a/Dockerfile b/Dockerfile index 2c8695e..84f2f8f 100644 --- a/Dockerfile +++ b/Dockerfile @@ -1,5 +1,5 @@ # https://github.com/84codes/crystal-container-images -FROM 84codes/crystal:1.15.0-ubuntu-24.04 AS builder +FROM 84codes/crystal:1.14.1-ubuntu-24.04 AS builder LABEL org.opencontainers.image.title="runway" LABEL org.opencontainers.image.description="clearing code for take off" diff --git a/shard.yml b/shard.yml index 89ef63b..14c4eb1 100644 --- a/shard.yml +++ b/shard.yml @@ -8,7 +8,7 @@ targets: runway: main: src/cli.cr -crystal: ">= 1.15.0" +crystal: ">= 1.14.1" license: MIT