Skip to content

Commit 21b2de3

Browse files
committed
powerpc: Fix build of some debug irq code
There was a typo, checking for CONFIG_TRACE_IRQFLAG instead of CONFIG_TRACE_IRQFLAGS causing some useful debug code to not be built This in turns causes a build error on BookE 64-bit due to incorrect semicolons at the end of a couple of macros, so let's fix that too Signed-off-by: Benjamin Herrenschmidt <[email protected]> CC: [email protected] [v3.4]
1 parent be2cf20 commit 21b2de3

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

arch/powerpc/include/asm/hw_irq.h

+2-2
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ static inline bool arch_irqs_disabled(void)
8686
}
8787

8888
#ifdef CONFIG_PPC_BOOK3E
89-
#define __hard_irq_enable() asm volatile("wrteei 1" : : : "memory");
90-
#define __hard_irq_disable() asm volatile("wrteei 0" : : : "memory");
89+
#define __hard_irq_enable() asm volatile("wrteei 1" : : : "memory")
90+
#define __hard_irq_disable() asm volatile("wrteei 0" : : : "memory")
9191
#else
9292
#define __hard_irq_enable() __mtmsrd(local_paca->kernel_msr | MSR_EE, 1)
9393
#define __hard_irq_disable() __mtmsrd(local_paca->kernel_msr, 1)

arch/powerpc/kernel/irq.c

+1-1
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ notrace void arch_local_irq_restore(unsigned long en)
229229
*/
230230
if (unlikely(irq_happened != PACA_IRQ_HARD_DIS))
231231
__hard_irq_disable();
232-
#ifdef CONFIG_TRACE_IRQFLAG
232+
#ifdef CONFIG_TRACE_IRQFLAGS
233233
else {
234234
/*
235235
* We should already be hard disabled here. We had bugs

0 commit comments

Comments
 (0)