-
-
Notifications
You must be signed in to change notification settings - Fork 939
/
Copy pathuser_multifactor_methods_test.rb
547 lines (408 loc) · 17.2 KB
/
user_multifactor_methods_test.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
require "test_helper"
class UserMultifactorMethodsTest < ActiveSupport::TestCase
include ActionMailer::TestHelper
setup do
@user = create(:user)
end
context "validation" do
context "#mfa_level_for_enabled_devices" do
context "when mfa_level is disabled" do
should "be valid if there no mfa devices" do
assert_predicate @user, :valid?
assert_predicate @user, :no_mfa_devices?
end
should "be invalid if totp is enabled" do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
@user.mfa_level = :disabled
refute_predicate @user, :valid?
end
should "be invalid if webauthn is enabled" do
create(:webauthn_credential, user: @user)
@user.mfa_level = :disabled
refute_predicate @user, :valid?
end
should "be invalid if both totp and webauthn are enabled" do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
create(:webauthn_credential, user: @user)
@user.mfa_level = :disabled
refute_predicate @user, :valid?
end
end
context "when mfa_level is ui_and_gem_signin" do
should "be invalid if there no mfa devices" do
@user.mfa_level = :ui_and_gem_signin
assert_predicate @user, :no_mfa_devices?
refute_predicate @user, :valid?
end
should "be valid if totp is enabled" do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
@user.mfa_level = :ui_and_gem_signin
assert_predicate @user, :valid?
end
should "be valid if webauthn is enabled" do
create(:webauthn_credential, user: @user)
@user.mfa_level = :ui_and_gem_signin
assert_predicate @user, :valid?
end
should "be valid if both totp and webauthn are enabled" do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
create(:webauthn_credential, user: @user)
@user.mfa_level = :ui_and_gem_signin
assert_predicate @user, :valid?
end
end
context "when mfa_level is ui_and_api" do
should "be invalid if there no mfa devices" do
@user.mfa_level = :ui_and_api
assert_predicate @user, :no_mfa_devices?
refute_predicate @user, :valid?
end
should "be valid if totp is enabled" do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
@user.mfa_level = :ui_and_api
assert_predicate @user, :valid?
end
should "be valid if webauthn is enabled" do
create(:webauthn_credential, user: @user)
@user.mfa_level = :ui_and_api
assert_predicate @user, :valid?
end
should "be valid if both totp and webauthn are enabled" do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
create(:webauthn_credential, user: @user)
@user.mfa_level = :ui_and_api
assert_predicate @user, :valid?
end
end
end
end
context "#mfa_enabled" do
should "return true if multifactor auth is not disabled using totp" do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_only)
assert_predicate @user, :mfa_enabled?
end
should "return false if multifactor auth is disabled using totp" do
@user.disable_totp!
refute_predicate @user, :mfa_enabled?
end
should "return true if multifactor auth is not disabled using WebAuthn" do
create(:webauthn_credential, user: @user)
assert_predicate @user, :mfa_enabled?
end
should "return true if multifactor auth is disabled using WebAuthn" do
create(:webauthn_credential, user: @user)
@user.webauthn_credentials.first.destroy
refute_predicate @user, :mfa_enabled?
end
should "send totp enabled email" do
assert_emails 1 do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_gem_signin)
end
assert_equal "Authentication app enabled on RubyGems.org", last_email.subject
assert_equal [@user.email], last_email.to
end
end
context "#mfa_device_count_one?" do
should "return true if user has one webauthn credential and no totp" do
create(:webauthn_credential, user: @user)
assert_predicate @user, :mfa_device_count_one?
end
should "return true if user has totp enabled and no webauthn credential" do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
assert_predicate @user, :mfa_device_count_one?
end
should "return false if user has totp enabled and one webauthn credential" do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
create(:webauthn_credential, user: @user)
refute_predicate @user, :mfa_device_count_one?
end
should "return false if user has no totp and no webauthn credential" do
refute_predicate @user, :mfa_device_count_one?
end
should "return false if user has two webauthn credentials" do
create(:webauthn_credential, user: @user)
create(:webauthn_credential, user: @user)
refute_predicate @user, :mfa_device_count_one?
end
end
context "#no_mfa_devices?" do
should "return true if user has no totp and no webauthn credential" do
assert_predicate @user, :no_mfa_devices?
end
should "return false if user has one webauthn credential" do
create(:webauthn_credential, user: @user)
refute_predicate @user, :no_mfa_devices?
end
should "return false if user has totp enabled" do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
refute_predicate @user, :no_mfa_devices?
end
should "return false if user has totp and webauthn enabled" do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
create(:webauthn_credential, user: @user)
refute_predicate @user, :no_mfa_devices?
end
end
context "#mfa_gem_signin_authorized?" do
setup do
@seed = ROTP::Base32.random_base32
end
context "with totp" do
should "return true when correct and if mfa is ui_and_api" do
@user.enable_totp!(@seed, :ui_and_api)
assert @user.mfa_gem_signin_authorized?(ROTP::TOTP.new(@seed).now)
end
should "return true when correct and if mfa is ui_and_gem_signin" do
@user.enable_totp!(@seed, :ui_and_gem_signin)
assert @user.mfa_gem_signin_authorized?(ROTP::TOTP.new(@seed).now)
end
should "return false when incorrect" do
@user.enable_totp!(@seed, :ui_and_gem_signin)
refute @user.mfa_gem_signin_authorized?(ROTP::TOTP.new(ROTP::Base32.random_base32).now)
end
end
context "with webauthn otp" do
should "return true when correct and if mfa is ui_and_api" do
@user.enable_totp!(@seed, :ui_and_api)
webauthn_verification = create(:webauthn_verification, user: @user)
assert @user.mfa_gem_signin_authorized?(webauthn_verification.otp)
end
should "return true when correct and if mfa is ui_and_gem_signin" do
@user.enable_totp!(@seed, :ui_and_gem_signin)
webauthn_verification = create(:webauthn_verification, user: @user)
assert @user.mfa_gem_signin_authorized?(webauthn_verification.otp)
end
should "return true when correct and if mfa is disabled" do
webauthn_verification = create(:webauthn_verification, user: @user)
assert @user.mfa_gem_signin_authorized?(webauthn_verification.otp)
end
should "return false when incorrect" do
@user.enable_totp!(@seed, :ui_and_gem_signin)
create(:webauthn_verification, user: @user, otp: "jiEm2mm2sJtRqAVx7U1i")
incorrect_otp = "Yxf57d1wEUSWyXrrLMRv"
refute @user.mfa_gem_signin_authorized?(incorrect_otp)
end
end
should "return true if mfa is disabled" do
assert @user.mfa_gem_signin_authorized?(ROTP::TOTP.new(@seed).now)
end
should "return true if mfa is ui_only" do
@user.enable_totp!(@seed, :ui_only)
assert @user.mfa_gem_signin_authorized?(ROTP::TOTP.new(@seed).now)
end
end
context "#mfa_recommended_not_yet_enabled?" do
setup do
@popular_rubygem = create(:rubygem)
GemDownload.increment(
Rubygem::MFA_RECOMMENDED_THRESHOLD + 1,
rubygem_id: @popular_rubygem.id
)
end
should "return true if instance owns a gem that exceeds recommended threshold and has mfa disabled" do
create(:ownership, user: @user, rubygem: @popular_rubygem)
assert_predicate @user, :mfa_recommended_not_yet_enabled?
end
should "return false if instance owns a gem that exceeds recommended threshold and has mfa enabled" do
create(:ownership, user: @user, rubygem: @popular_rubygem)
@user.enable_totp!(ROTP::Base32.random_base32, :ui_only)
refute_predicate @user, :mfa_recommended_not_yet_enabled?
end
should "return false if instance does not own a gem that exceeds recommended threshold and has mfa disabled" do
create(:ownership, user: @user, rubygem: create(:rubygem))
refute_predicate @user, :mfa_recommended_not_yet_enabled?
end
end
context "#mfa_recommended_weak_level_enabled?" do
setup do
@popular_rubygem = create(:rubygem)
GemDownload.increment(
Rubygem::MFA_RECOMMENDED_THRESHOLD + 1,
rubygem_id: @popular_rubygem.id
)
@user.enable_totp!(ROTP::Base32.random_base32, :ui_only)
end
should "return true if instance owns a gem that exceeds recommended threshold and has mfa ui_only" do
create(:ownership, user: @user, rubygem: @popular_rubygem)
assert_predicate @user, :mfa_recommended_weak_level_enabled?
end
should "return false if instance owns a gem that exceeds recommended threshold and has mfa disabled" do
create(:ownership, user: @user, rubygem: @popular_rubygem)
@user.disable_totp!
refute_predicate @user, :mfa_recommended_weak_level_enabled?
end
should "return false if instance does not own a gem that exceeds recommended threshold and has mfa disabled" do
create(:ownership, user: @user, rubygem: create(:rubygem))
refute_predicate @user, :mfa_recommended_weak_level_enabled?
end
end
context "#mfa_required_not_yet_enabled?" do
setup do
@popular_rubygem = create(:rubygem)
GemDownload.increment(
Rubygem::MFA_REQUIRED_THRESHOLD + 1,
rubygem_id: @popular_rubygem.id
)
end
should "return true if instance owns a gem that exceeds required threshold and has mfa disabled" do
create(:ownership, user: @user, rubygem: @popular_rubygem)
assert_predicate @user, :mfa_required_not_yet_enabled?
end
should "return false if instance owns a gem that exceeds required threshold and has mfa enabled" do
create(:ownership, user: @user, rubygem: @popular_rubygem)
@user.enable_totp!(ROTP::Base32.random_base32, :ui_only)
refute_predicate @user, :mfa_required_not_yet_enabled?
end
should "return false if instance does not own a gem that exceeds required threshold and has mfa disabled" do
create(:ownership, user: @user, rubygem: create(:rubygem))
refute_predicate @user, :mfa_required_not_yet_enabled?
end
end
context "#mfa_required_weak_level_enabled?" do
setup do
@popular_rubygem = create(:rubygem)
GemDownload.increment(
Rubygem::MFA_REQUIRED_THRESHOLD + 1,
rubygem_id: @popular_rubygem.id
)
@user.enable_totp!(ROTP::Base32.random_base32, :ui_only)
end
should "return true if instance owns a gem that exceeds required threshold and has mfa ui_only" do
create(:ownership, user: @user, rubygem: @popular_rubygem)
assert_predicate @user, :mfa_required_weak_level_enabled?
end
should "return false if instance owns a gem that exceeds required threshold and has mfa disabled" do
create(:ownership, user: @user, rubygem: @popular_rubygem)
@user.disable_totp!
refute_predicate @user, :mfa_required_weak_level_enabled?
end
should "return false if instance does not own a gem that exceeds required threshold and has mfa disabled" do
create(:ownership, user: @user, rubygem: create(:rubygem))
refute_predicate @user, :mfa_required_weak_level_enabled?
end
end
context "#ui_mfa_verified?" do
setup do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
end
context "with totp" do
should "return true when correct" do
assert @user.ui_mfa_verified?(ROTP::TOTP.new(@user.totp_seed).now)
end
should "return true when correct in last interval" do
last_otp = ROTP::TOTP.new(@user.totp_seed).at(Time.current - 30)
assert @user.ui_mfa_verified?(last_otp)
end
should "return true when correct in next interval" do
next_otp = ROTP::TOTP.new(@user.totp_seed).at(Time.current + 30)
assert @user.ui_mfa_verified?(next_otp)
end
should "return false when incorrect" do
refute @user.ui_mfa_verified?(ROTP::TOTP.new(ROTP::Base32.random_base32).now)
end
should "return false if the mfa_seed is blank" do
@user.disable_totp!
refute @user.ui_mfa_verified?(ROTP::TOTP.new(ROTP::Base32.random_base32).now)
end
should "return false when reused" do
code = ROTP::TOTP.new(@user.totp_seed).now
assert @user.ui_mfa_verified?(code)
refute @user.ui_mfa_verified?(code)
end
should "return true after waiting for the next interval" do
code = ROTP::TOTP.new(@user.totp_seed).now
assert @user.ui_mfa_verified?(code)
travel_to 30.seconds.from_now do
refute @user.ui_mfa_verified?(code)
assert @user.ui_mfa_verified?(ROTP::TOTP.new(@user.totp_seed).now)
end
end
end
context "with webauthn otp" do
should "return false" do
webauthn_verification = create(:webauthn_verification, user: @user)
refute @user.ui_mfa_verified?(webauthn_verification.otp)
end
end
should "return true if recovery code is correct" do
recovery_code = @user.new_mfa_recovery_codes.first
assert @user.ui_mfa_verified?(recovery_code)
refute(@user.mfa_hashed_recovery_codes.any? { |code| BCrypt::Password.new(code) == recovery_code })
end
end
context "#api_mfa_verified?" do
setup do
@user.enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
end
context "with totp" do
should "return true when correct" do
assert @user.api_mfa_verified?(ROTP::TOTP.new(@user.totp_seed).now)
end
should "return true when correct in last interval" do
last_otp = ROTP::TOTP.new(@user.totp_seed).at(Time.current - 30)
assert @user.api_mfa_verified?(last_otp)
end
should "return true when correct in next interval" do
next_otp = ROTP::TOTP.new(@user.totp_seed).at(Time.current + 30)
assert @user.api_mfa_verified?(next_otp)
end
should "return false if otp is incorrect" do
refute @user.api_mfa_verified?(ROTP::TOTP.new(ROTP::Base32.random_base32).now)
end
should "return false when reused" do
code = ROTP::TOTP.new(@user.totp_seed).now
assert @user.api_mfa_verified?(code)
refute @user.api_mfa_verified?(code)
end
should "return true after waiting for the next interval" do
code = ROTP::TOTP.new(@user.totp_seed).now
assert @user.api_mfa_verified?(code)
travel_to 30.seconds.from_now do
refute @user.api_mfa_verified?(code)
assert @user.api_mfa_verified?(ROTP::TOTP.new(@user.totp_seed).now)
end
end
end
context "with webauthn otp" do
should "return true when correct" do
webauthn_verification = create(:webauthn_verification, user: @user)
assert @user.api_mfa_verified?(webauthn_verification.otp)
end
should "return false when incorrect" do
create(:webauthn_verification, user: @user, otp: "jiEm2mm2sJtRqAVx")
incorrect_otp = "Yxf57d1wEUSWyXrr"
refute @user.api_mfa_verified?(incorrect_otp)
end
should "return false when expired" do
webauthn_verification = create(:webauthn_verification, user: @user, otp_expires_at: 2.minutes.ago)
refute @user.api_mfa_verified?(webauthn_verification.otp)
end
context "when webauthn otp has not been generated" do
setup do
create(:webauthn_verification, user: @user, otp: nil, otp_expires_at: nil)
end
should "return false for an otp" do
refute @user.api_mfa_verified?("Yxf57d1wEUSWyXrr")
end
should "return false if otp is nil" do
refute @user.api_mfa_verified?(nil)
end
end
end
should "return true if recovery code is correct" do
recovery_code = @user.new_mfa_recovery_codes.first
assert @user.api_mfa_verified?(recovery_code)
refute(@user.mfa_hashed_recovery_codes.any? { |code| BCrypt::Password.new(code) == recovery_code })
end
end
context ".without_mfa" do
setup do
create(:user).enable_totp!(ROTP::Base32.random_base32, :ui_and_api)
end
should "return instances without mfa" do
user_without_mfa = User.without_mfa
assert_equal 1, user_without_mfa.size
assert_equal @user, user_without_mfa.first
end
end
end